Skip to content

[Unit Tests] Add ExtraOre and ItsATriple mining ability tests #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DiamondDagger590 wants to merge 1 commit into from
Closed

[Unit Tests] Add ExtraOre and ItsATriple mining ability tests #361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
174 changes: 174 additions & 0 deletions src/test/java/us/eunoians/mcrpg/ability/impl/mining/ExtraOreTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,174 @@
package us.eunoians.mcrpg.ability.impl.mining;

import com.diamonddagger590.mccore.registry.RegistryAccess;
import com.diamonddagger590.mccore.registry.RegistryKey;
import dev.dejvokep.boostedyaml.YamlDocument;
import org.bukkit.Location;
import org.bukkit.World;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Nested;
import org.junit.jupiter.api.Test;
import us.eunoians.mcrpg.McRPGBaseTest;
import us.eunoians.mcrpg.configuration.FileManager;
import us.eunoians.mcrpg.configuration.FileType;
import us.eunoians.mcrpg.configuration.file.skill.MiningConfigFile;
import us.eunoians.mcrpg.entity.holder.AbilityHolder;
import us.eunoians.mcrpg.entity.holder.SkillHolder;
import us.eunoians.mcrpg.registry.manager.McRPGManagerKey;
import us.eunoians.mcrpg.skill.impl.mining.Mining;

import java.util.Optional;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;

/**
* Tests for {@link ExtraOre} configuration value resolution, multiplier map,
* and metadata accessors.
* <p>
* ExtraOre uses the holder's mining level via the {@code mining_level} Parser variable
* rather than a tier-based route lookup.
*/
class ExtraOreTest extends McRPGBaseTest {

private YamlDocument miningConfig;
private ExtraOre extraOre;

@BeforeEach
void setUp() {
miningConfig = mock(YamlDocument.class);
FileManager fileManager = RegistryAccess.registryAccess()
.registry(RegistryKey.MANAGER)
.manager(McRPGManagerKey.FILE);
when(fileManager.getFile(FileType.MINING_CONFIG)).thenReturn(miningConfig);

extraOre = new ExtraOre(mcRPG);
}

@Nested
@DisplayName("getActivationChance")
class GetActivationChance {

@Test
@DisplayName("evaluates formula with mining_level variable")
void getActivationChance_evaluatesFormulaWithMiningLevel() {
int level = 10;
SkillHolder skillHolder = mock(SkillHolder.class);
SkillHolder.SkillHolderData skillHolderData = mock(SkillHolder.SkillHolderData.class);
when(skillHolder.getSkillHolderData(Mining.MINING_KEY)).thenReturn(Optional.of(skillHolderData));
when(skillHolderData.getCurrentLevel()).thenReturn(level);
when(miningConfig.getString(MiningConfigFile.EXTRA_ORE_ACTIVATION_EQUATION)).thenReturn("mining_level*2");

assertEquals(20.0, extraOre.getActivationChance(skillHolder), 0.001);
}

@Test
@DisplayName("returns literal value when given plain number")
void getActivationChance_returnsLiteral() {
SkillHolder skillHolder = mock(SkillHolder.class);
SkillHolder.SkillHolderData skillHolderData = mock(SkillHolder.SkillHolderData.class);
when(skillHolder.getSkillHolderData(Mining.MINING_KEY)).thenReturn(Optional.of(skillHolderData));
when(skillHolderData.getCurrentLevel()).thenReturn(5);
when(miningConfig.getString(MiningConfigFile.EXTRA_ORE_ACTIVATION_EQUATION)).thenReturn("30");

assertEquals(30.0, extraOre.getActivationChance(skillHolder), 0.001);
}

@Test
@DisplayName("returns zero when skill data is absent")
void getActivationChance_returnsZero_whenNoMiningData() {
SkillHolder skillHolder = mock(SkillHolder.class);
when(skillHolder.getSkillHolderData(Mining.MINING_KEY)).thenReturn(Optional.empty());

assertEquals(0.0, extraOre.getActivationChance(skillHolder), 0.001);
}
}

@Nested
@DisplayName("Multiplier map")
class MultiplierMap {

@Test
@DisplayName("starts empty")
void getMultiplierMap_startsEmpty() {
assertTrue(extraOre.getMultiplierMap().isEmpty());
}

@Test
@DisplayName("addMultiplier stores entry in map")
void addMultiplier_storesEntry() {
World world = mock(World.class);
Location location = new Location(world, 10, 20, 30);
extraOre.addMultiplier(location, 2);

assertTrue(extraOre.isBlockMultiplied(location));
assertEquals(2, extraOre.getMultiplier(location));
}

@Test
@DisplayName("getMultiplier returns 1 for unmapped location")
void getMultiplier_returnsDefault_whenNotMapped() {
World world = mock(World.class);
Location location = new Location(world, 99, 99, 99);

assertEquals(1, extraOre.getMultiplier(location));
}
}

@Nested
@DisplayName("Reloadable content")
class ReloadableContentTests {

@Test
@DisplayName("getReloadableContent returns non-empty set")
void getReloadableContent_returnsNonEmptySet() {
assertFalse(extraOre.getReloadableContent().isEmpty());
}

@Test
@DisplayName("getValidBlockTypes returns non-null")
void getValidBlockTypes_returnsNonNull() {
assertNotNull(extraOre.getValidBlockTypes());
}
}

@Nested
@DisplayName("Metadata")
class Metadata {

@Test
@DisplayName("getAbilityKey returns EXTRA_ORE_KEY")
void getAbilityKey_returnsExtraOreKey() {
assertEquals(ExtraOre.EXTRA_ORE_KEY, extraOre.getAbilityKey());
}

@Test
@DisplayName("getSkillKey returns MINING_KEY")
void getSkillKey_returnsMiningKey() {
assertEquals(Mining.MINING_KEY, extraOre.getSkillKey());
}

@Test
@DisplayName("getDatabaseName returns extra_ore")
void getDatabaseName_returnsExtraOre() {
assertEquals("extra_ore", extraOre.getDatabaseName());
}

@Test
@DisplayName("getAbilityEnabledRoute returns correct route")
void getAbilityEnabledRoute_returnsCorrectRoute() {
assertEquals(MiningConfigFile.EXTRA_ORE_ENABLED, extraOre.getAbilityEnabledRoute());
}

@Test
@DisplayName("getYamlDocument returns non-null")
void getYamlDocument_returnsNonNull() {
assertNotNull(extraOre.getYamlDocument());
}
}
}
153 changes: 153 additions & 0 deletions src/test/java/us/eunoians/mcrpg/ability/impl/mining/ItsATripleTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,153 @@
package us.eunoians.mcrpg.ability.impl.mining;

import com.diamonddagger590.mccore.registry.RegistryAccess;
import com.diamonddagger590.mccore.registry.RegistryKey;
import dev.dejvokep.boostedyaml.YamlDocument;
import dev.dejvokep.boostedyaml.route.Route;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Nested;
import org.junit.jupiter.api.Test;
import us.eunoians.mcrpg.McRPGBaseTest;
import us.eunoians.mcrpg.configuration.FileManager;
import us.eunoians.mcrpg.configuration.FileType;
import us.eunoians.mcrpg.configuration.file.skill.MiningConfigFile;
import us.eunoians.mcrpg.registry.manager.McRPGManagerKey;
import us.eunoians.mcrpg.skill.impl.mining.Mining;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;

/**
* Tests for {@link ItsATriple} configuration value resolution and metadata accessors.
* <p>
* ItsATriple is a tierable ability that uses the {@code tier} Parser variable
* with tier-specific route fallback to all-tiers.
*/
class ItsATripleTest extends McRPGBaseTest {

private YamlDocument miningConfig;
private ItsATriple itsATriple;

@BeforeEach
void setUp() {
miningConfig = mock(YamlDocument.class);
FileManager fileManager = RegistryAccess.registryAccess()
.registry(RegistryKey.MANAGER)
.manager(McRPGManagerKey.FILE);
when(fileManager.getFile(FileType.MINING_CONFIG)).thenReturn(miningConfig);

itsATriple = new ItsATriple(mcRPG);
}

@Nested
@DisplayName("getActivationChance")
class GetActivationChance {

@Test
@DisplayName("evaluates formula with tier variable")
void getActivationChance_evaluatesFormulaWithTier() {
int tier = 3;
Route allTiersRoute = Route.addTo(MiningConfigFile.ITS_A_TRIPLE_CONFIGURATION_HEADER, "all-tiers");
Route chanceAllTiers = Route.addTo(allTiersRoute, "activation-chance");
Route tierRoute = Route.addTo(
Route.addTo(MiningConfigFile.ITS_A_TRIPLE_CONFIGURATION_HEADER, "tier-" + tier),
"activation-chance");

when(miningConfig.contains(tierRoute)).thenReturn(false);
when(miningConfig.getString(chanceAllTiers)).thenReturn("10*tier");

assertEquals(30.0, itsATriple.getActivationChance(tier), 0.001);
}

@Test
@DisplayName("returns literal value when given plain number")
void getActivationChance_returnsLiteral() {
int tier = 1;
Route allTiersRoute = Route.addTo(MiningConfigFile.ITS_A_TRIPLE_CONFIGURATION_HEADER, "all-tiers");
Route chanceAllTiers = Route.addTo(allTiersRoute, "activation-chance");
Route tierRoute = Route.addTo(
Route.addTo(MiningConfigFile.ITS_A_TRIPLE_CONFIGURATION_HEADER, "tier-" + tier),
"activation-chance");

when(miningConfig.contains(tierRoute)).thenReturn(false);
when(miningConfig.getString(chanceAllTiers)).thenReturn("25");

assertEquals(25.0, itsATriple.getActivationChance(tier), 0.001);
}

@Test
@DisplayName("prefers tier-specific route over all-tiers")
void getActivationChance_prefersTierSpecific() {
int tier = 2;
Route allTiersRoute = Route.addTo(MiningConfigFile.ITS_A_TRIPLE_CONFIGURATION_HEADER, "all-tiers");
Route chanceAllTiers = Route.addTo(allTiersRoute, "activation-chance");
Route tierRoute = Route.addTo(
Route.addTo(MiningConfigFile.ITS_A_TRIPLE_CONFIGURATION_HEADER, "tier-" + tier),
"activation-chance");

when(miningConfig.contains(tierRoute)).thenReturn(true);
when(miningConfig.getString(tierRoute)).thenReturn("50");
when(miningConfig.getString(chanceAllTiers)).thenReturn("10*tier");

assertEquals(50.0, itsATriple.getActivationChance(tier), 0.001);
}
}

@Nested
@DisplayName("Metadata")
class Metadata {

@Test
@DisplayName("getAbilityKey returns ITS_A_TRIPLE_KEY")
void getAbilityKey_returnsItsATripleKey() {
assertEquals(ItsATriple.ITS_A_TRIPLE_KEY, itsATriple.getAbilityKey());
}

@Test
@DisplayName("getSkillKey returns MINING_KEY")
void getSkillKey_returnsMiningKey() {
assertEquals(Mining.MINING_KEY, itsATriple.getSkillKey());
}

@Test
@DisplayName("getDatabaseName returns its_a_triple")
void getDatabaseName_returnsItsATriple() {
assertEquals("its_a_triple", itsATriple.getDatabaseName());
}

@Test
@DisplayName("getMaxTier reads from config")
void getMaxTier_readsFromConfig() {
when(miningConfig.getInt(MiningConfigFile.ITS_A_TRIPLE_AMOUNT_OF_TIERS)).thenReturn(5);

assertEquals(5, itsATriple.getMaxTier());
}

@Test
@DisplayName("getAbilityEnabledRoute returns correct route")
void getAbilityEnabledRoute_returnsCorrectRoute() {
assertEquals(MiningConfigFile.ITS_A_TRIPLE_ENABLED, itsATriple.getAbilityEnabledRoute());
}

@Test
@DisplayName("getAbilityTierConfigurationRoute returns correct route")
void getAbilityTierConfigurationRoute_returnsCorrectRoute() {
assertEquals(MiningConfigFile.ITS_A_TRIPLE_CONFIGURATION_HEADER, itsATriple.getAbilityTierConfigurationRoute());
}

@Test
@DisplayName("getYamlDocument returns non-null")
void getYamlDocument_returnsNonNull() {
assertNotNull(itsATriple.getYamlDocument());
}

@Test
@DisplayName("getApplicableAttributes returns non-null set")
void getApplicableAttributes_returnsNonNull() {
assertNotNull(itsATriple.getApplicableAttributes());
}
}
}
Loading