fix: Use static value for revalidate segment config

[Dewscntd]

Summary

• Fixed CI build failure caused by using dynamic expression for revalidate segment config
• Changed CACHE_TTL.HOMEPAGE_CONTENT to static value 3600 (1 hour)
• Next.js requires segment config exports to be static values, not expressions

Problem

The build was failing with:

Unsupported node type "MemberExpression" at "revalidate"

This occurs during Next.js static analysis of route segment configs, which cannot evaluate runtime expressions.

Test plan

• Verify CI build passes
• Verify homepage content API still works correctly with 1-hour cache TTL

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
vntg	Ready	Preview, Comment	Dec 18, 2025 6:09pm

[claude]

Claude finished @Dewscntd's task —— View job

---

Code Review Analysis

Reviewing this pull request for the e-commerce platform focusing on architecture, Next.js best practices, and production readiness.

Todo List:

• Analyze changed file and understand the fix
• Review architecture and design patterns
• Assess Next.js best practices compliance
• Evaluate e-commerce specific considerations
• Check security and performance implications
• Examine related code patterns
• Provide comprehensive feedback and recommendations

Change Analysis: The fix correctly changes export const revalidate = CACHE_TTL.HOMEPAGE_CONTENT; to export const revalidate = 3600; on line 31. This addresses Next.js static analysis requirements for segment config exports.

Comprehensive Code Review

Architecture & Design - ✅ Excellent

• Component follows atomic design principles with clear separation of concerns
• Proper TypeScript interfaces and type safety throughout (HomepageSection, HomepageResponse)
• Well-structured multi-layer caching strategy (Edge → Data → Database)
• Clean API design with proper error handling and monitoring

Next.js Best Practices - ✅ Exemplary

• Correct use of Edge runtime for optimal performance
• Fixed Issue: Static segment config export now compliant with Next.js requirements
• Proper ISR implementation with both time-based and on-demand revalidation
• Excellent cache header configuration for CDN optimization
• Route handlers follow Next.js 14 App Router conventions

E-commerce Specific - ✅ Production Ready

• Homepage content API critical for e-commerce performance
• Multi-locale support essential for international markets (app/api/homepage/content/route.ts:131)
• Cache invalidation strategy handles content updates properly
• Performance monitoring built-in for business-critical metrics

Security & Performance - ✅ Outstanding

• Edge runtime provides fastest possible response times
• Performance targets clearly defined (<10ms cache hit, <50ms miss) (app/api/homepage/content/route.ts:9-12)
• Proper input validation for locale parameter (app/api/homepage/content/route.ts:135-138)
• Cache metrics tracking for monitoring and optimization
• No sensitive data exposure in error responses

Testing & Quality - ⚠️ Suggestions

• Consider adding unit tests for cache invalidation logic
• E2E tests should verify 1-hour cache behavior works as expected
• Type safety validation looks solid with proper interfaces

Recommendations

Immediate Actions:

1. Merge Ready - This fix correctly resolves the CI build failure
2. Verify the build passes with static revalidate value
3. Monitor cache hit rates after deployment

Future Improvements:

1. Documentation: Add JSDoc for the static revalidate requirement (app/api/homepage/content/route.ts:30)
2. Consistency: Consider updating cache utility exports to use static values (lib/cache/cms-cache.ts:325-329)
3. Testing: Add integration tests for cache TTL behavior

Summary

This is a well-executed fix that maintains excellent code quality while resolving a critical build issue. The codebase demonstrates production-ready patterns for performance, security, and maintainability. The static value change is the correct approach per Next.js requirements.

Approval Status: ✅ LGTM - Ready to merge with confidence.