fix(landing): hero clip bleed, legible 3D stat text, warm dark surfaces, themed body bg#121
Merged
Merged
Conversation
… surfaces, themed body bg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feedback round 4 — four fixes, verified locally in both themes at parallax extremes.
1. Canvas clipping on interaction
The hero canvas raster was exactly the visual box, so tilting coupons/droplets got guillotined at the edge. The canvas now bleeds 48px/40px past its layout box (
-inset-x-[48px] -inset-y-[40px]; layout box unchanged → zero CLS), the scene's fit math computes against the layout-box slice of the frustum (composition size unchanged, bleed is pure clip headroom), and the droplets moved inside the fitted group with a tightened y-spread so nothing ever touches the raster edge (derivations in comments).2. Stat text barely visible
Number 0.3→0.34, label 0.088→0.11 at full opacity with tighter letterSpacing (longest label fit-proof in a comment), stronger ink-shadow outlines.
3. Off-brand blue in dark mode (coupons + supported stores)
Tailwind's cool
gray-800/900(blue-hued) swapped for a new warm tokendarkSurface: #1E1916across coupons + supported-site components, incl. the react-select inline hexes; blue-tinteddark:border-gray-*→dark:border-white/10; semantic green/amber/red tints untouched; light mode untouched.4. White padding strip
Root cause: the
dark/lightclass lives on an inner wrapper,<body>had no background — default white peeked at the bottom sliver/overscroll/scrollbar gutters. Fixed in globals.css withhtml:has(.dark)-based rules so html+body always match the real page bg in both themes.Out-of-scope note:
sources/page.tsxandPasswordChecker.tsxalso carry cooldark:border-gray-*— left for a later sweep (outside the reported pages).Gates green: tsc, prettier, oxlint, knip, three-lazy-boundary + repo-integrity, full unit suite (406). Dev only — no prod.
🤖 Generated with Claude Code