fix: enhance secret handling by masking sensitive values in logs and updating parameter resolution - #14
Merged
Merged
Conversation
…and updating parameter resolution
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances secret handling by masking sensitive values in logs and updating parameter resolution methods. The changes aim to prevent exposure of sensitive information in log outputs while maintaining functionality for testing environments.
- Simplified secret masking logic by removing pattern-based detection and always masking values
- Added test-mode detection to conditionally log sensitive information only during tests
- Updated parameter resolution method names and signatures for clarity
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/common/params/params.go | Updated masking logic to always mask values and simplified the API |
| internal/common/params/params_test.go | Updated tests to match new masking behavior and method signatures |
| internal/common/params/constants.go | Removed sensitive pattern constants that are no longer used |
| internal/checker/utils.go | Added test mode detection and conditional logging utilities |
| internal/checker/endpoints.go | Replaced direct logging with conditional test-only logging |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11
Type of change
Please delete options that are not relevant.
Checklist