fix(site): auto-scroll detail panel into view on mobile when a measure is selected - #69
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix mobile auto scroll for Measure details
fix(site): auto-scroll detail panel into view on mobile when a measure is selected
Jun 18, 2026
DevSecNinja
marked this pull request as ready for review
June 18, 2026 15:49
Contributor
|
🔍 Preview deployed: https://edc40cd5.grip-visualizer.pages.dev Updated: Thu, 18 Jun 2026 15:51:16 GMT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On mobile (≤ 1080 px, single-column layout), the
MeasureDetailPanelrenders below the measure grid. Selecting a measure updates the panel content but leaves it off-screen, requiring a manual scroll.Changes
MeasureDetailPanel— adds auseRef/useEffectthat callsscrollIntoViewwhenevermeasurechanges, gated onwindow.innerWidth <= 1080(matching the CSS breakpoint where the layout collapses to one column). On desktop the panel is already visible in its sticky side-column, so the guard is a no-op there.The
typeof scrollIntoView === 'function'guard prevents a crash in the jsdom test environment, which does not implement this DOM API.