Skip to content

client testing - #8468

Closed
Bayheck wants to merge 3 commits into
DevExpress:masterfrom
Bayheck:testing-gulp-qunit
Closed

client testing#8468
Bayheck wants to merge 3 commits into
DevExpress:masterfrom
Bayheck:testing-gulp-qunit

Conversation

@Bayheck

@Bayheck Bayheck commented Dec 14, 2025

Copy link
Copy Markdown
Collaborator

Purpose

Describe the problem you want to address or the feature you want to implement.

Approach

Describe how your changes address the issue or implement the desired functionality in as much detail as possible.

References

Provide a link to the existing issue(s), if any.

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

@Bayheck
Bayheck requested a review from aleks-pro as a code owner December 14, 2025 15:38
Copilot AI review requested due to automatic review settings December 14, 2025 15:38
@testcafe-need-response-bot testcafe-need-response-bot Bot added the STATE: Need response An issue that requires a response or attention from the team. label Dec 14, 2025
@Bayheck Bayheck removed the STATE: Need response An issue that requires a response or attention from the team. label Dec 14, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the gulp-qunit-harness dependency from version ^1.0.3 to 1.1.0, changing the source from npm registry to a GitHub-hosted tarball from a personal repository.

Key Changes

  • Replaces gulp-qunit-harness dependency source from npm registry to a GitHub tarball URL
  • Updates the underlying qunit-harness package to @devexpress/qunit-harness v1.5.0
  • Increases minimum Node.js version requirement from ">= 0.10" to ">= 18.0.0"

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
package.json Updates gulp-qunit-harness dependency source to GitHub tarball URL
package-lock.json Reflects dependency tree changes including new @devexpress scoped packages, version updates for transitive dependencies (axios, form-data, @types/node), and minimum Node.js version requirement change

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json Outdated
"gulp-mocha-simple": "^2.0.0",
"gulp-mustache": "^3.0.1",
"gulp-qunit-harness": "^1.0.3",
"gulp-qunit-harness": "https://github.com/Bayheck/Builds/raw/main/gulp-qunit-harness-1.1.0.tgz",

Copilot AI Dec 14, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a direct GitHub URL to download a tarball from a personal repository raises security and maintainability concerns. This approach bypasses npm's registry verification and version management. The package source should be from a trusted npm registry or official repository. Consider publishing this version to npm registry or using a properly tagged GitHub release with semantic versioning.

Suggested change
"gulp-qunit-harness": "https://github.com/Bayheck/Builds/raw/main/gulp-qunit-harness-1.1.0.tgz",
"gulp-qunit-harness": "^1.1.0",

Copilot uses AI. Check for mistakes.
@Bayheck Bayheck closed this Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants