Skip to content

Scheduler: current_time_shader refactor — pass config object instead of whole workspace#33931

Open
bit-byte0 wants to merge 1 commit into
DevExpress:26_1from
bit-byte0:refactor/shader-pass-container-not-workspace
Open

Scheduler: current_time_shader refactor — pass config object instead of whole workspace#33931
bit-byte0 wants to merge 1 commit into
DevExpress:26_1from
bit-byte0:refactor/shader-pass-container-not-workspace

Conversation

@bit-byte0

Copy link
Copy Markdown
Contributor

What:

Base CurrentTimeShader no longer depends on the entire workspace. It receives only the $container element it actually uses

How:

Subclasses now own the workSpace reference and pass workSpace.getScrollable().$content() to super()

@bit-byte0 bit-byte0 self-assigned this Jun 9, 2026
Copilot AI review requested due to automatic review settings June 9, 2026 16:48
@bit-byte0 bit-byte0 requested a review from a team as a code owner June 9, 2026 16:48
@bit-byte0 bit-byte0 added the 26_1 label Jun 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the Scheduler “current time shader” implementation so the base CurrentTimeShader no longer depends on the full workspace instance, reducing coupling inside the internal scheduler shaders layer.

Changes:

  • CurrentTimeShader now receives the scrollable content container ($container) via constructor instead of accessing it through a SchedulerWorkSpace.
  • Horizontal/Vertical shader subclasses now own the workSpace reference and pass workSpace.getScrollable().$content() to super().

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/devextreme/js/__internal/scheduler/shaders/current_time_shader.ts Base shader now depends only on $container rather than the whole workspace.
packages/devextreme/js/__internal/scheduler/shaders/current_time_shader_vertical.ts Adds workspace-owned constructor and forwards scrollable $content() to the base shader.
packages/devextreme/js/__internal/scheduler/shaders/current_time_shader_horizontal.ts Adds workspace-owned constructor and forwards scrollable $content() to the base shader.

Comment thread packages/devextreme/js/__internal/scheduler/shaders/current_time_shader.ts Outdated
@bit-byte0 bit-byte0 force-pushed the refactor/shader-pass-container-not-workspace branch from d56567e to c1d8779 Compare June 9, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants