Scheduler: current_time_shader refactor — pass config object instead of whole workspace#33931
Open
bit-byte0 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the Scheduler “current time shader” implementation so the base CurrentTimeShader no longer depends on the full workspace instance, reducing coupling inside the internal scheduler shaders layer.
Changes:
CurrentTimeShadernow receives the scrollable content container ($container) via constructor instead of accessing it through aSchedulerWorkSpace.- Horizontal/Vertical shader subclasses now own the
workSpacereference and passworkSpace.getScrollable().$content()tosuper().
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/scheduler/shaders/current_time_shader.ts | Base shader now depends only on $container rather than the whole workspace. |
| packages/devextreme/js/__internal/scheduler/shaders/current_time_shader_vertical.ts | Adds workspace-owned constructor and forwards scrollable $content() to the base shader. |
| packages/devextreme/js/__internal/scheduler/shaders/current_time_shader_horizontal.ts | Adds workspace-owned constructor and forwards scrollable $content() to the base shader. |
d56567e to
c1d8779
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Base
CurrentTimeShaderno longer depends on the entire workspace. It receives only the$containerelement it actually usesHow:
Subclasses now own the
workSpacereference and passworkSpace.getScrollable().$content()tosuper()