WG Demos - Update editorType/widget import statements for scheduler-related widget demos#33921
Open
charlescordialDevExpress wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Scheduler-related demo apps (Vue/React/Angular) to ensure DevExtreme widgets referenced by string (widget="dxButton", editorType="dxSelectBox") are properly registered via explicit side-effect imports, aligning the demos with modular import behavior.
Changes:
- Added
import 'devextreme/ui/button'to Scheduler Toolbar demos where toolbar items instantiatedxButtonby widget name. - Added
import 'devextreme/ui/select_box'to Scheduler Templates demos where form items instantiatedxSelectBoxby editorType. - Removed
DxButtonModulefrom the Angular Scheduler Toolbar demo’s standaloneimportslist since the demo doesn’t render an Angular<dx-button>component.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/demos/Demos/Scheduler/Toolbar/Vue/App.vue | Registers dxButton for Scheduler toolbar items using widget="dxButton". |
| apps/demos/Demos/Scheduler/Toolbar/ReactJs/App.js | Registers dxButton for Scheduler toolbar items using widget="dxButton". |
| apps/demos/Demos/Scheduler/Toolbar/React/App.tsx | Registers dxButton for Scheduler toolbar items using widget="dxButton". |
| apps/demos/Demos/Scheduler/Toolbar/Angular/app/app.component.ts | Registers dxButton via side-effect import and removes unused DxButtonModule from standalone imports. |
| apps/demos/Demos/Scheduler/Templates/Vue/App.vue | Registers dxSelectBox for Scheduler form items using editor-type="dxSelectBox". |
| apps/demos/Demos/Scheduler/Templates/ReactJs/App.js | Registers dxSelectBox for Scheduler form items using editorType="dxSelectBox". |
| apps/demos/Demos/Scheduler/Templates/React/App.tsx | Registers dxSelectBox for Scheduler form items using editorType="dxSelectBox". |
| apps/demos/Demos/Scheduler/Templates/Angular/app/app.component.ts | Registers dxSelectBox for Scheduler form items using editorType="dxSelectBox". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR change?
How did you achieve this?
How can we verify these changes?