WG Demos - Update editorType/widget import statements for Grid-related widget demos#33919
Open
charlescordialDevExpress wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates several grid-related demo apps (DataGrid/CardView across Angular/React/Vue) so editorType/widget-based editors load the correct DevExtreme widget modules via direct devextreme/ui/* side-effect imports, avoiding reliance on framework wrapper modules for registration.
Changes:
- Added direct widget module imports (e.g.,
devextreme/ui/button,devextreme/ui/text_area,devextreme/ui/select_box) where demos configurewidget="dxButton"/editorType="dxTextArea"/editorType="dxSelectBox". - Removed Angular wrapper modules (
DxButtonModule,DxTextAreaModule,DxSelectBoxModule) from demo componentimportswhere the widgets are referenced viawidget/editorTyperather than Angular components. - Cleaned up a couple of React entrypoints by removing an eslint disable comment (needs to be kept for consistency with other demos’
anti-forgeryimport).
Reviewed changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/demos/Demos/DataGrid/Toolbar/Vue/App.vue | Ensures dxButton toolbar items are registered via devextreme/ui/button. |
| apps/demos/Demos/DataGrid/Toolbar/ReactJs/App.js | Ensures dxButton toolbar items are registered via devextreme/ui/button. |
| apps/demos/Demos/DataGrid/Toolbar/React/App.tsx | Ensures dxButton toolbar items are registered via devextreme/ui/button. |
| apps/demos/Demos/DataGrid/Toolbar/Angular/app/app.component.ts | Switches from Angular button module usage to direct devextreme/ui/button registration for widget="dxButton". |
| apps/demos/Demos/DataGrid/PopupEditing/Vue/App.vue | Switches TextArea registration to devextreme/ui/text_area for editor-type="dxTextArea". |
| apps/demos/Demos/DataGrid/PopupEditing/ReactJs/App.js | Switches TextArea registration to devextreme/ui/text_area for editorType="dxTextArea". |
| apps/demos/Demos/DataGrid/PopupEditing/React/App.tsx | Switches TextArea registration to devextreme/ui/text_area for editorType="dxTextArea". |
| apps/demos/Demos/DataGrid/PopupEditing/Angular/app/app.component.ts | Drops DxTextAreaModule and registers dxTextArea via devextreme/ui/text_area. |
| apps/demos/Demos/DataGrid/FormEditing/Vue/App.vue | Switches TextArea registration to devextreme/ui/text_area for editor-type="dxTextArea". |
| apps/demos/Demos/DataGrid/FormEditing/ReactJs/App.js | Switches TextArea registration to devextreme/ui/text_area for editorType="dxTextArea". |
| apps/demos/Demos/DataGrid/FormEditing/React/App.tsx | Switches TextArea registration to devextreme/ui/text_area for editorType="dxTextArea". |
| apps/demos/Demos/DataGrid/FormEditing/Angular/app/app.component.ts | Drops DxTextAreaModule and registers dxTextArea via devextreme/ui/text_area. |
| apps/demos/Demos/CardView/WebAPIService/Vue/App.vue | Adds devextreme/ui/select_box for editor-type="dxSelectBox". |
| apps/demos/Demos/CardView/WebAPIService/ReactJs/App.js | Adds devextreme/ui/select_box for editorType="dxSelectBox". |
| apps/demos/Demos/CardView/WebAPIService/React/index.tsx | Removes an eslint disable comment above anti-forgery import (should be retained to avoid lint errors). |
| apps/demos/Demos/CardView/WebAPIService/React/App.tsx | Adds devextreme/ui/select_box for editorType="dxSelectBox". |
| apps/demos/Demos/CardView/WebAPIService/Angular/app/app.component.ts | Drops DxSelectBoxModule and registers dxSelectBox via devextreme/ui/select_box. |
| apps/demos/Demos/CardView/PopupEditing/Vue/App.vue | Switches TextArea registration to devextreme/ui/text_area for editor-type="dxTextArea". |
| apps/demos/Demos/CardView/PopupEditing/ReactJs/App.js | Switches TextArea registration to devextreme/ui/text_area for editorType="dxTextArea". |
| apps/demos/Demos/CardView/PopupEditing/React/App.tsx | Switches TextArea registration to devextreme/ui/text_area for editorType="dxTextArea". |
| apps/demos/Demos/CardView/PopupEditing/Angular/app/app.component.ts | Drops DxTextAreaModule and registers dxTextArea via devextreme/ui/text_area. |
| apps/demos/Demos/CardView/DataValidation/Vue/App.vue | Switches TextArea registration to devextreme/ui/text_area for editor-type="dxTextArea". |
| apps/demos/Demos/CardView/DataValidation/ReactJs/App.js | Registers dxTextArea via devextreme/ui/text_area. |
| apps/demos/Demos/CardView/DataValidation/React/index.tsx | Removes an eslint disable comment above anti-forgery import (should be retained to avoid lint errors). |
| apps/demos/Demos/CardView/DataValidation/React/App.tsx | Registers dxTextArea via devextreme/ui/text_area. |
| apps/demos/Demos/CardView/DataValidation/Angular/app/app.component.ts | Drops DxTextAreaModule and registers dxTextArea via devextreme/ui/text_area. |
Comment on lines
4
to
6
| import App from './App.tsx'; | ||
| // eslint-disable-next-line import/no-unresolved | ||
|
|
||
| import 'anti-forgery'; |
Comment on lines
4
to
6
| import App from './App.tsx'; | ||
| // eslint-disable-next-line import/no-unresolved | ||
|
|
||
| import 'anti-forgery'; |
Comment on lines
+71
to
73
| import 'devextreme/ui/select_box'; | ||
| import * as AspNetData from 'devextreme-aspnet-data-nojquery'; | ||
| import 'devextreme-vue/text-area'; |
Comment on lines
4
to
+5
| import 'devextreme-react/text-area'; | ||
| import 'devextreme/ui/select_box'; |
Comment on lines
12
to
+13
| import 'devextreme-react/text-area'; | ||
| import 'devextreme/ui/select_box'; |
charlescordialDevExpress
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR change?
How did you achieve this?
How can we verify these changes?