CardView - Header filter search is only triggered once when remoteOperations is true (T1305672)#33899
Open
markallenramirez wants to merge 2 commits into
Open
CardView - Header filter search is only triggered once when remoteOperations is true (T1305672)#33899markallenramirez wants to merge 2 commits into
markallenramirez wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CardView/grid “new” DataController deferred caching behavior so cache hits are less likely to occur when call arguments differ only in deeper nested properties—addressing cases where header filter search with remoteOperations: true was only triggering once.
Changes:
- Adjusted
deferredCacheargument equality check to useequalByValue(..., { maxDepth: 5 })instead of the default depth. - Ensures deeper load-option changes are detected and do not incorrectly reuse cached results.
Alyar666
reviewed
Jun 9, 2026
Alyar666
left a comment
Alyar666
left a comment
Contributor
There was a problem hiding this comment.
Please add an end-to-end test that covers the actual user scenario.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.