Skip to content

fix typo in readme #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DetachHead merged 6 commits into from
Apr 13, 2026
Merged

fix typo in readme #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
31859fa
fix missing `async` in readme example
DetachHead Apr 13, 2026
bfd65a8
remove abandoned git graph vscode extension from recommendations
DetachHead Apr 13, 2026
551d9a0
update vscode config to no longer use deprecated typescript settings
DetachHead Apr 13, 2026
255d850
add `node_modules/.bin` to `PATH` in vscode terminal
DetachHead Apr 13, 2026
357a07d
update package-lock.json
DetachHead Apr 13, 2026
5a89490
why does ths ci fucking break on its own every time i revisit this pr…
DetachHead Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/test and publish.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ jobs:
options: --user 1001
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f
with:
node-version-file: package.json
- run: npm ci
- run: npm run check
- name: upload compiled code
Expand Down Expand Up @@ -61,9 +64,9 @@ jobs:
pull-requests: read
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f
with:
node-version: 16.9.1
node-version-file: package.json
- run: echo ::set-output name=CURRENT_VERSION::$(node -p "require(\"./package.json\").version")
id: current-version
- if: github.ref == 'refs/heads/master'
Expand Down
1 change: 0 additions & 1 deletion .vscode/extensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"recommendations": [
"esbenp.prettier-vscode",
"dbaeumer.vscode-eslint",
"mhutchie.git-graph",
"ms-playwright.playwright",
"github.vscode-github-actions"
]
Expand Down
15 changes: 12 additions & 3 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"typescript.tsdk": "node_modules/typescript/lib",
"js/ts.tsdk.path": "node_modules/typescript/lib",
"js/ts.tsdk.promptToUseWorkspaceVersion": true,
"editor.formatOnSave": true,
"prettier.configPath": ".prettierrc.json",
"editor.defaultFormatter": "esbenp.prettier-vscode",
Expand All @@ -18,7 +19,15 @@
"git.useCommitInputAsStashMessage": true,
"diffEditor.ignoreTrimWhitespace": false,
"files.eol": "\n",
"typescript.enablePromptUseWorkspaceTsdk": true,
"editor.acceptSuggestionOnCommitCharacter": false,
"git.useEditorAsCommitInput": false
"git.useEditorAsCommitInput": false,
"terminal.integrated.env.windows": {
"PATH": "${workspaceFolder}/node_modules/.bin;${env:PATH}"
},
"terminal.integrated.env.osx": {
"PATH": "${workspaceFolder}/node_modules/.bin:${env:PATH}"
},
"terminal.integrated.env.linux": {
"PATH": "${workspaceFolder}/node_modules/.bin:${env:PATH}"
}
}
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ test.beforeAll(async () => {
await selectors.register('ui5', css)
})

test('ui5 example', ({ page }) => {
test('ui5 example', async ({ page }) => {
await page.goto('https://ui5.sap.com/')
await page.click("ui5=sap.m.Button[text='Get Started with UI5']")
})
Expand Down
17 changes: 15 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@
"throw-expression": "^1.0.2",
"xmlbuilder2": "^3.1.1"
},
"devEngines": {
"runtime": {"name": "node", "version": "24.14.1"}
},
"//": [
"https://github.com/trivago/prettier-plugin-sort-imports/issues/204#issuecomment-1431287240",
"https://github.com/DetachHead/eslint-plugin-detachhead/blob/master/docs/rules/suggestions-as-errors.md#troubleshooting"
Expand Down
Loading