Skip to content

Testing ESM migration - #1

Open
Desplandis wants to merge 2 commits into
masterfrom
migrate/esm
Open

Testing ESM migration#1
Desplandis wants to merge 2 commits into
masterfrom
migrate/esm

Conversation

@Desplandis

Copy link
Copy Markdown
Owner

TODOs

  • npm start works
  • Unit testing works
  • Linting works
  • Functional testing works
  • Embedding in another project

@coveralls

coveralls commented Mar 21, 2024

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 8378462500

Details

  • 246 of 287 (85.71%) changed or added relevant lines in 9 files are covered.
  • 1708 unchanged lines in 94 files lost coverage.
  • Overall coverage increased (+11.4%) to 89.306%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Provider/Fetcher.js 30 31 96.77%
src/Provider/3dTilesProvider.js 10 16 62.5%
src/Parser/B3dmParser.js 64 71 90.14%
src/Source/VectorTilesSource.js 53 61 86.89%
src/Parser/GLTFParser.js 73 92 79.35%
Files with Coverage Reduction New Missed Lines %
src/Parser/LASParser.js 1 96.77%
src/Core/Geographic/Crs.js 1 98.24%
src/Converter/textureConverter.js 1 93.65%
src/Layer/ElevationLayer.js 1 95.73%
src/Core/TileMesh.js 1 97.24%
src/Provider/PointCloudProvider.js 1 94.55%
src/Parser/CameraCalibrationParser.js 1 90.74%
src/Core/3DTiles/C3DTExtensions.js 2 97.14%
src/Parser/KMLParser.js 2 89.29%
src/Utils/FeaturesUtils.js 2 97.46%
Totals Coverage Status
Change from base Build 8295380731: 11.4%
Covered Lines: 23228
Relevant Lines: 25440

💛 - Coveralls

@Desplandis
Desplandis force-pushed the migrate/esm branch 6 times, most recently from 9bc5763 to 04391f4 Compare March 21, 2024 16:00
This includes:
- all scripts under the docs repository (publish.js is loaded with
  require())
- all eslintrc config scripts (loaded with require())
- grunt/bump script (loaded with require())
- conventional changelog script (loaded with require())
- webpack.config
BREAKING CHANGE: The itowns library drops the CommonJS distribution in favor of
a standard ECMAScript module (ESM) distribution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants