Skip to content

Chore/ruff linting - #1739

Open
jarosenb wants to merge 5 commits into
mainfrom
chore/ruff-linting
Open

jarosenb wants to merge 5 commits into
mainfrom
chore/ruff-linting

Conversation

@jarosenb

Copy link
Copy Markdown
Member

Overview

Enable Ruff linting. As a first pass, the lint checks are passing and being enforced on the designsafe/apps directory.

PR Status

  • Ready.
  • Work in Progress.
  • Hold.

Summary of Changes

  • Install and configure Ruff in pyproject.toml
  • Implement fixes for failing checks in designsafe/apps
  • Add a Ruff linting step to the GitHub CI pipeline.

Once this is working, it's recommended to disable the pylint extension in your editor/IDE and install/enable a Ruff extension.

Testing Steps

  1. poetry install
  2. poetry run ruff check designsafe/apps

@fnets fnets left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor cleanup and suggested change

Comment thread .github/workflows/main.yml
Comment thread .github/workflows/main.yml Outdated

@fnets fnets left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants