fix: use correct target name ExFigCLI for DocC build - #50
Conversation
The package has no target named 'ExFig' — the main target is 'ExFigCLI'. Updated all DocC build commands and the documentation catalog symbol reference. https://claude.ai/code/session_01MeeYwatPCABmWk43FpzntD
Summary of ChangesHello @alexey1312, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical misconfiguration in the project's documentation generation process. It ensures that the DocC build system correctly identifies and uses the Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly updates the DocC build target from ExFig to ExFigCLI in the documentation catalog and build scripts. The changes are accurate and address the issue described. I have one minor suggestion for the mise.toml file to improve the robustness of the generated documentation's URL paths.
| generate-documentation --target ExFigCLI \ | ||
| --disable-indexing \ | ||
| --transform-for-static-hosting \ | ||
| --hosting-base-path ExFig \ |
There was a problem hiding this comment.
The hosting-base-path on line 141 should start with a / to be treated as an absolute path from the host's root (e.g., /ExFig). This makes the generated URLs more robust and aligns with the swift-docc-plugin documentation. I've included this fix along with your change to the target.
generate-documentation --target ExFigCLI \
--disable-indexing \
--transform-for-static-hosting \
--hosting-base-path /ExFig \
The package has no target named 'ExFig' — the main target is 'ExFigCLI'.
Updated all DocC build commands and the documentation catalog symbol reference.
https://claude.ai/code/session_01MeeYwatPCABmWk43FpzntD