Skip to content

⚡ Bolt: Optimize SVG number parsing #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
google-labs-jules wants to merge 1 commit into from
Closed

⚡ Bolt: Optimize SVG number parsing #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Sources/SVGKit/SVGPathParser.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,9 @@ public enum SVGParseError: Error, LocalizedError {
// MARK: - Internal Scanner

private final class PathScanner: @unchecked Sendable {
private let originalInput: String
private let input: String.UTF8View
private var index: String.UTF8View.Index
private var index: String.Index

// Lookup table for whitespace characters
// 0x09: tab, 0x0A: line feed, 0x0C: form feed, 0x0D: carriage return, 0x20: space
Expand All @@ -183,6 +184,7 @@ private final class PathScanner: @unchecked Sendable {
}

init(_ input: String) {
originalInput = input
self.input = input.utf8
index = self.input.startIndex
}
Expand Down Expand Up @@ -260,7 +262,10 @@ private final class PathScanner: @unchecked Sendable {
}

let slice = input[startIndex ..< index]
guard !slice.isEmpty, let string = String(slice), let value = Double(string) else {
// OPTIMIZATION: Use Substring from original string to avoid String allocation from UTF8View slice.
// Swift's Double.init<S>(_ text: S) where S : StringProtocol handles Substring efficiently.
let substring = originalInput[startIndex ..< index]
guard !slice.isEmpty, let value = Double(substring) else {
if slice.isEmpty { return nil }
// Using Array(slice) to create [UInt8] for String decoding
let bytes = Array(slice)
Expand Down
Loading