Skip to content

feat(svg): add Tree Traversal API support via swift-resvg upgrade - #19

Merged
alexey1312 merged 4 commits into
mainfrom
claude/svg-tree-traversal-api-s7LUb
Dec 27, 2025
Merged

feat(svg): add Tree Traversal API support via swift-resvg upgrade#19
alexey1312 merged 4 commits into
mainfrom
claude/svg-tree-traversal-api-s7LUb

Conversation

@alexey1312

Copy link
Copy Markdown
Collaborator
  • Update swift-resvg to v0.45.1-swift.3 which includes Tree Traversal API
  • Add ResvgPathConverter utility for converting resvg path segments to SVG path strings
  • Add extractPathFromMask/extractPathFromClipPath helpers for VectorDrawable clip-path conversion
  • Add comprehensive tests for tree traversal, mask extraction, and path conversion

The Tree Traversal API enables direct access to usvg tree structure for:

  • Extracting mask content for clip-path conversion (Figma flags)
  • Accessing path fill/stroke properties
  • Traversing group hierarchies with transforms

- Update swift-resvg to v0.45.1-swift.3 which includes Tree Traversal API
- Add ResvgPathConverter utility for converting resvg path segments to SVG path strings
- Add extractPathFromMask/extractPathFromClipPath helpers for VectorDrawable clip-path conversion
- Add comprehensive tests for tree traversal, mask extraction, and path conversion

The Tree Traversal API enables direct access to usvg tree structure for:
- Extracting mask content for clip-path conversion (Figma flags)
- Accessing path fill/stroke properties
- Traversing group hierarchies with transforms
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @alexey1312, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the SVG processing capabilities by upgrading the swift-resvg dependency to v0.45.1-swift.3, which integrates the powerful Tree Traversal API. This new API allows for granular interaction with SVG tree structures, enabling the introduction of a ResvgPathConverter utility. This utility, along with dedicated helper functions, streamlines the extraction and conversion of complex SVG path data from masks and clip-paths, particularly addressing compatibility challenges when converting designs from tools like Figma to VectorDrawable. The changes are thoroughly tested to ensure robustness and correctness.

Highlights

  • Dependency Upgrade: The swift-resvg dependency has been updated to version 0.45.1-swift.3.
  • Tree Traversal API Support: This upgrade introduces support for the Tree Traversal API, allowing direct access to the usvg tree structure.
  • New Path Conversion Utility: A new ResvgPathConverter utility has been added to convert resvg path segments into standard SVG path strings.
  • Mask and Clip-Path Extraction Helpers: Helper functions (extractPathFromMask, extractPathFromClipPath) are now available to extract path data from SVG masks and clip-paths, which is crucial for VectorDrawable conversion, especially for Figma-style designs.
  • Comprehensive Testing: Extensive unit tests have been added to validate the new tree traversal, mask extraction, and path conversion functionalities.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a great addition, upgrading swift-resvg to enable a new Tree Traversal API and introducing a ResvgPathConverter utility to leverage it. The implementation is solid and accompanied by a comprehensive set of tests. My feedback focuses on a few areas for improvement: enhancing performance in string generation, reducing code duplication in the new utility for better maintainability, and strengthening test assertions to make them more specific and robust against future changes. Overall, these changes effectively add valuable new capabilities for SVG processing.

Comment thread Sources/SVGKit/ResvgPathConverter.swift Outdated
Comment thread Sources/SVGKit/ResvgPathConverter.swift Outdated
Comment thread Sources/SVGKit/ResvgPathConverter.swift
Comment thread Tests/SVGKitTests/ResvgPathConverterTests.swift Outdated
Comment thread Tests/SVGKitTests/ResvgPathConverterTests.swift
- Use array building with join() instead of string concatenation for better performance
- Simplify extractPathFromMask/extractPathFromClipPath by delegating to extractPathFromGroup
- Make extractPathFromGroup public for direct reuse
- Improve test assertions with more specific checks (hasPrefix, hasSuffix, coordinate verification)
@alexey1312
alexey1312 merged commit c5b2ccb into main Dec 27, 2025
3 checks passed
@alexey1312
alexey1312 deleted the claude/svg-tree-traversal-api-s7LUb branch December 27, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants