Feat/denny/fix - #7
Closed
DennySORA wants to merge 3 commits into
Closed
Conversation
1. Add bandit[toml]>=1.7.0 to dev dependency group for CI security scans 2. Update fastapi to >=0.118,<0.119 and add starlette>=0.47.2,<0.48 to address security vulnerabilities (GHSA-2jv5-9r88-3w3p) 3. Replace SHA-1 with SHA-256 in file comparison module for better cryptographic security Root cause of CI failure: - Bandit was configured in pyproject.toml but not listed as a dependency - CI workflow ran 'uv run bandit' causing "No such file or directory" error Security improvements: - SHA-256 is more resistant to collision attacks than deprecated SHA-1 - Updated dependencies address known vulnerabilities - Bandit static analysis now properly configured for CI/CD pipeline Verified: ✅ uv run bandit --version works (returns 1.8.6) ✅ Bandit scan runs successfully ✅ All 382 tests pass in ~0.4 seconds ✅ Code quality checks pass (ruff format, ruff check, mypy) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> fix: cicd issue and update code. fix: cicd issue and update code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.