Zarrv3b csl md - #1
Open
mannreis wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following your suggestions in PR2992. I've added the consolidated zarr access as a dispatch layer for the operations handling the zarr json object (files). Is this what you envisioned?
I had to cherry-pick 2 commits (e8bb351bd52018ab0f71f0eb837f71283789ccce and 80d886a5d4aecd0e300b66c4beaa4ac0de912417) from upstream to have a build that I could test with.
So far I've only tested V2 consolidated read access (only implemented in open-read). But I also tried it using an HTTP server and a OpenStack Swift.
Could you please check 463795607429a2f8b64375c5a56c00bfb92c1475. All these changes allow to use the S3 implementation against general HTTP servers, which is something we really want.