Skip to content

Fix Homebrew dependency ordering #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Demonbane18 merged 1 commit into from
Aug 10, 2026
Merged

Fix Homebrew dependency ordering #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/generate-package-manager-manifests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ export function createHomebrewFormula({ sha256, version }) {
sha256 "${digest}"
license "Apache-2.0"

depends_on "node"
depends_on "python" => :build
depends_on "node"

def install
system "npm", "install", *std_npm_args
Expand Down
5 changes: 5 additions & 0 deletions test/package-manager.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,11 @@ test("Homebrew candidate follows the standard Node formula layout", () => {
assert.match(formula, /url "https:\/\/registry\.npmjs\.org\/relmio\/-\/relmio-1\.2\.3\.tgz"/u);
assert.match(formula, /depends_on "node"/u);
assert.match(formula, /depends_on "python" => :build/u);
assert.ok(
formula.indexOf('depends_on "python" => :build') <
formula.indexOf('depends_on "node"'),
"Homebrew build dependencies must precede runtime dependencies",
);
assert.match(formula, /system "npm", "install", \*std_npm_args/u);
assert.match(formula, /bin\.install_symlink libexec\.glob\("bin\/\*"\)/u);
assert.match(formula, /assert_predicate bin\/"relmio", :executable\?/u);
Expand Down
Loading