Fix curl installer terminal handoff - #32
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
/dev/ttyto both the installed-Node and portable-Node Relmio launch pathscurl | shpipeline, both runtime paths, no-terminal failure, and the Git Bash fixtureWhy
The installer historically redirected the Relmio process from
/dev/nullso it would not consume the remaining curl pipe. After the CLI began requiring interactive stdin and stdout, that redirect guaranteed a non-interactive launch and produced the “interactive terminal” error even from a real terminal.Impact
curl -fsSL https://relmio.vercel.app/install.sh | shcan open the local wizard again while still failing clearly when no controlling terminal exists. PowerShell, CMD, and npm behavior are unchanged.Validation
npm run check— 123 passed, 6 Windows-only skipped, 0 failedsh -n web/public/install.shgit diff --checknpm audit --audit-level=highnpm pack --dry-runNative Windows CI remains required before merge. After merge, the live Vercel installer and external Homebrew tap will be synchronized and verified by the release-everywhere audit.