Skip to content

Add Xquik news provider and modernize financial models#14

Open
kriptoburak wants to merge 1 commit into
DemonDamon:mainfrom
kriptoburak:codex/add-xquik-news-provider
Open

Add Xquik news provider and modernize financial models#14
kriptoburak wants to merge 1 commit into
DemonDamon:mainfrom
kriptoburak:codex/add-xquik-news-provider

Conversation

@kriptoburak

@kriptoburak kriptoburak commented Jun 21, 2026

Copy link
Copy Markdown

Summary

  • Add an optional Xquik provider that maps X post search results into the existing financial NewsData model.
  • Register it at the lowest priority so current financial news sources remain preferred.
  • Complete pagination up to the configured 500-result limit and handle cursor loops safely.
  • Keep credentials out of diagnostics, validate missing credentials, and normalize timestamps and date filters.

Independent repository fix

The existing NewsData and StockData models used deprecated Pydantic v1 configuration. This PR migrates both models to Pydantic v2 ConfigDict and updates their smoke tests so deprecation warnings are treated as errors.

Validation

  • All 43 financial tests pass with the complete optional dependency set.
  • Pydantic deprecations are errors during the changed-surface test run.
  • Ruff, new-provider pydocstyle, compilation, and diff checks pass.
  • DeepSource passes with 0 blocking issues, 0 failing metrics, and grade A in every dimension.
  • The branch contains exactly 1 SSH-signed commit on current main.

Xquik is an independent third-party service. Not affiliated with X Corp. "Twitter" and "X" are trademarks of X Corp.

@deepsource-io

deepsource-io Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

DeepSource Code Review

We reviewed changes in eb13a7f...1449616 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
Python Jul 19, 2026 9:36p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@kriptoburak kriptoburak changed the title Add optional Xquik news provider Add Xquik news provider and modernize financial models Jul 17, 2026
@kriptoburak

Copy link
Copy Markdown
Author

Resolved the current DeepSource report and refreshed this branch against the latest main.

  • Fixed every reported spacing, documentation, and static-method finding.
  • Preserved the optional Xquik provider and Pydantic v2 model modernization.
  • Re-ran 34 focused financial tests with Pydantic deprecations treated as errors.
  • Re-ran Ruff, pydocstyle, compilation, diff checks, and merge simulation.
  • Confirmed the new DeepSource run passes with 0 issues.

The PR is cleanly mergeable and ready for maintainer review.

@kriptoburak
kriptoburak force-pushed the codex/add-xquik-news-provider branch from 76730db to 1449616 Compare July 19, 2026 21:36
@kriptoburak

Copy link
Copy Markdown
Author

Repaired the branch in 1449616. The newer DeepSource activity is fully satisfied: Python analysis passes with 0 blocking issues and 0 failing metrics. The branch is now exactly one SSH-signed commit on current main. All 43 financial tests pass with the complete optional dependency set; Ruff, new-provider pydocstyle, compilation, Pydantic deprecation checks, and Git diff checks also pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant