Add irrigation proof-of-concept#3148
Open
HendrikKok wants to merge 4 commits into
Open
Conversation
…h external irrigation allocation, synthetic forcing, and multi-column example plots
There was a problem hiding this comment.
Trivy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
HendrikKok
marked this pull request as ready for review
July 14, 2026 12:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3118
Irrigation module; proof-of-concept
Adds a standalone
irrigation/module wrapping Wflow's SBM land-surfacecomponents (soil, interception, runoff, non-paddy demand) to prototype a
coupled irrigation loop with Ribasim.
Structure
Coupling concept
Each timestep has the following update pattern:
sequenceDiagram participant W as Irrigation module participant A as Allocation (LP) participant P as Physical layer (ODE) loop every allocation timestep Note over W: get_demand!() — soil state @ t-1 W->>A: demand [m/s] → user_demand.demand Note over A: update_allocation!()<br/>LP solve for t A->>P: allocated flows [m³/s] Note over P: SciMLBase.step!()<br/>ODE water balance solve for t P->>W: realized volumes [m³] Note over W: update!() — advance soil to t endOnline coupling API
Notes
ea8754e(1.1.0-dev) via[sources]inirrigation/Project.toml; remove when 1.1.0 is released to the registryrun_irrigation_standalone.jlruns three standalone scenarios (no allocation / 50% / multi-column) and saves water budget plotsrun_irrigation_coupled.pygenerates the Ribasim model and runscoupled_simulation.jl, saving the same water budget plotsIO design
irrigation_forcingtableSoilConfig,VegetationConfig,IrrigationConfig); could be overridden from HydroMT NetCDF output in the futureirrigation_id → UserDemand nodemapping is implicit: each UserDemand node withirrigation = truegets one soil column;irr.node_id(held by Ribasim) is the ordered index into the soil column vector — no separate config neededOpen questions