Skip to content

GRIDEDIT-2172: Build macOS binaries using clang #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahmad-el-sayed merged 4 commits into from
Apr 21, 2026
Merged

GRIDEDIT-2172: Build macOS binaries using clang #270

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
83763ac
Use clang and try exporting OpenMP_ROOT
ahmad-el-sayed Apr 20, 2026
cc8a5b7
bump version of actions/upload-artifact to latest because current wil…
ahmad-el-sayed Apr 20, 2026
32d7ec7
remove redundant CC and CXX env var settings, will this affect the te…
ahmad-el-sayed Apr 21, 2026
22cbe64
Merge branch 'main' into feature/GRIDEDIT-2172-use-clang
ahmad-el-sayed Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 11 additions & 15 deletions .github/workflows/build-and-test-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,6 @@ jobs:

# Build steps
steps:
# Step: Install GCC (macOS only)
- name: Install GCC
if: startsWith(runner.os, 'macOS')
run: |
brew install gcc@12
echo "CC=$(brew --prefix)/bin/gcc-12" >> $GITHUB_ENV
echo "CXX=$(brew --prefix)/bin/g++-12" >> $GITHUB_ENV

# Step: Checkout
- name: Checkout
Expand All @@ -50,8 +43,7 @@ jobs:
# macOS
- name: Install backend dependencies
run: | # brew update
brew install boost
brew install doxygen
brew install boost doxygen libomp

- name: Process branch name
id: process_branch_name
Expand All @@ -71,15 +63,19 @@ jobs:
echo "BACK_END_BRANCH=$str" >> $GITHUB_ENV

# Step: Build Wheel
# The default compiler on macos is clang, switch to gcc 11. Specifying the version is necessary.
# It seems like gcc and g++ are symbolic links to the default clang and clang++ compilers, respectively.
# CMAKE_CXX_COMPILER_ID will evaluate to AppleClang rather than GNU on macos.
- name: Build Wheel
env:
CC: gcc-12
CXX: g++-12
CC: clang
CXX: clang++
Comment thread
ahmad-el-sayed marked this conversation as resolved.
Resolved
run: |
export MACOSX_DEPLOYMENT_TARGET=$(sw_vers -productVersion)
# Detect Homebrew prefix based on runner architecture
if [ "${{ runner.arch }}" = "ARM64" ]; then
HOMEBREW_PREFIX="/opt/homebrew"
else
HOMEBREW_PREFIX="/usr/local"
fi
export OpenMP_ROOT="$HOMEBREW_PREFIX/opt/libomp"
python setup.py build_ext
python setup.py sdist
python setup.py bdist_wheel
Expand Down Expand Up @@ -110,7 +106,7 @@ jobs:

# Step: Upload artifact
- name: Upload artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
if: always()
with:
name: meshkernel-${{ inputs.platform }}-${{ inputs.build_type }}
Expand Down