Skip to content

Fix macos tests #265

Closed
Closed

Description

@veenstrajelmer

What is the need for this task.
The macos tests are all failing with the following error:

CMake Error at cmake/compiler_config.cmake:29 (message):
  Unsupported compiler on macOS.  Supported: AppleClang/Clang.  Found GNU.

Full traceback:

Run export MACOSX_DEPLOYMENT_TARGET=$(sw_vers -productVersion)
/Library/Frameworks/Python.framework/Versions/3.14/lib/python3.14/site-packages/wheel/bdist_wheel.py:4: FutureWarning: The 'wheel' package is no longer the canonical location of the 'bdist_wheel' command, and will be removed in a future release. Please update to setuptools v70.1 or later which contains an integrated version of this command.
  warn(
running build_ext
/Users/runner/work/MeshKernelPy/MeshKernelPy/setup.py:32: DeprecationWarning: codecs.open() is deprecated. Use open() instead.
git clone https://github.com/Deltares/MeshKernel
  with codecs.open(os.path.join(here, rel_path), "r") as fp:
Cloning into 'MeshKernel'...
git -C ./MeshKernel switch -C feature/add-contacts-testcase origin/feature/add-contacts-testcase
fatal: invalid reference: origin/feature/add-contacts-testcase
command '/usr/local/bin/git' failed with exit code 128 (Invalid reference to branch origin/feature/add-contacts-testcase). Remaining on master branch.
git -C ./MeshKernel branch
* master
cmake -S . -B build -DCMAKE_BUILD_TYPE=Release -DENABLE_UNIT_TESTING=OFF
-- The CXX compiler identification is GNU 12.5.0
-- The C compiler identification is GNU 12.5.0
-- Checking whether CXX compiler has -isysroot
-- Checking whether CXX compiler has -isysroot - yes
-- Checking whether CXX compiler supports OSX deployment target flag
-- Checking whether CXX compiler supports OSX deployment target flag - yes
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/local/bin/g++-12 - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Checking whether C compiler has -isysroot
-- Checking whether C compiler has -isysroot - yes
-- Checking whether C compiler supports OSX deployment target flag
-- Checking whether C compiler supports OSX deployment target flag - yes
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/local/bin/gcc-12 - skipped
-- Detecting C compile features
-- Detecting C compile features - done
CMake Error at cmake/compiler_config.cmake:29 (message):
  Unsupported compiler on macOS.  Supported: AppleClang/Clang.  Found GNU.
Call Stack (most recent call first):
  CMakeLists.txt:16 (include)

-- Configuring incomplete, errors occurred!
error: command '/usr/local/bin/cmake' failed with exit code 1
Error: Process completed with exit code 1.

What is the task?
Fix the tests for macos

Alternatively
Drop support for macos, since it requires significant maintenance and not many users have macos. However, then we should also remove all meshkernel macos builds from pypi so users get an error upon installation (instead of an old mk version). This also means that users of dfm_tools, hydrolib-core and hydromt_delft3dfm cannot use macos anymore.

Activity

  1. added
    choreChanges to the build process or auxiliary tools and libraries such as documentation generation
    on Apr 1, 2026
  2. veenstrajelmer commented on Apr 7, 2026

    @veenstrajelmer
    CollaboratorAuthor
  3. veenstrajelmer commented on Apr 21, 2026

    @veenstrajelmer
    CollaboratorAuthor

    Fixed by #270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    choreChanges to the build process or auxiliary tools and libraries such as documentation generation

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions