Skip to content
This repository was archived by the owner on Jun 22, 2026. It is now read-only.

Update libraries, merge changes into main, publish package#1

Merged
philn-delphia merged 12 commits into
mainfrom
switch-to-delphia-fork
Apr 15, 2024
Merged

Update libraries, merge changes into main, publish package#1
philn-delphia merged 12 commits into
mainfrom
switch-to-delphia-fork

Conversation

@philn-delphia

@philn-delphia philn-delphia commented Apr 15, 2024

Copy link
Copy Markdown
Collaborator

Forking the original trstringer/manual-approval so we can continue diverging and supporting changes. Thanks to the authors of this great workflow and everyone who's contributed.

There's a PR to merge the ability to leave approvers blank in the original repo. This PR includes that, along with some updates and minor changes.

  • Publish the container under ghcr.io/delphia/manual-approval
  • Update golang, packages and alpine
  • Allow approvers to be empty. When empty, issue creator will be assigned to the issue but anyone with repo access can approve.
  • Small fixes like rewording titles to be shorter and linking to the run correctly.

@philn-delphia philn-delphia self-assigned this Apr 15, 2024

@samueldg samueldg left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thanks for porting the changes here and the improvements along the way.

I like the idea of maintaining a "changelog" in the README that justifies the existence of this fork 👌

@philn-delphia philn-delphia merged commit 9f2b88b into main Apr 15, 2024
@philn-delphia philn-delphia deleted the switch-to-delphia-fork branch April 15, 2024 18:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants