ci: fix python_check — test supported HA versions, satisfy mypy - #7
Merged
Conversation
The matrix still pinned HA 2024.2/2024.3 from upstream history, which the component no longer supports (DataUpdateCoordinator config_entry kwarg needs 2024.8+), so every commit failed CI regardless of its content. Test what the fork actually targets: 2026.5.4 (compat branch baseline) and latest 2026.6. Also bump checkout/setup-python actions off the deprecated node16 runtime. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- config_flow: FlowResult → ConfigFlowResult (HA 2024.4+ flow typing) - climate: narrow _attr_hvac_mode before returning it from hvac_mode - binary_sensor: wrap is_on comparison in bool() (device.get returns Any) - drop now-unused voluptuous type: ignore comments (ships typed since 0.14) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python_check failed on every commit because the matrix still tested HA 2024.2/2024.3 from upstream history, which the fork no longer supports (
DataUpdateCoordinator(config_entry=...)needs 2024.8+).ConfigFlowResultin config_flow,HVACMode | Nonenarrowing in climate,bool()in binary_sensor is_on, unused voluptuous ignoresVerified locally against HA 2026.6.2: flake8 0, mypy clean (17 files), black clean.
🤖 Generated with Claude Code