Skip to content

0.2.1: wait for the searcher, re-review on change, a home for the report - #8

Merged
LTSCommerce merged 2 commits into
mainfrom
fix/runbook-wait-review-report
Sep 30, 2026
Merged

LTSCommerce merged 2 commits into
mainfrom
fix/runbook-wait-review-report

Conversation

@LTSCommerce

@LTSCommerce LTSCommerce commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Fixes four defects found by an execution test of 0.2.0: a real defect in a TypeScript project, handed to a headless practitioner as a plain bug description, with the plugin installed at project scope. The skill fired unprompted and the rule was proven red before the fix, but the remediation did not conform.

  1. The runbook did not wait for its own searcher. Step 2 said to let the independent searcher run whilst the rule was written, and nothing said to wait for it, so the original was fixed before the search returned, and in -p mode the session emitted its final result whilst still incomplete. Step 2 now dispatches the searcher in the foreground, so its result is in hand before the rule is written, and forbids any fix, the original included, until the reconciliation at step 5.
  2. Review was one-shot. The rule was widened after the review and two commits landed unreviewed. The reviewer is now re-dispatched whenever resolving a finding changes the defence.
  3. The report had nowhere to go in a repository with no records place and no pull request, so nothing was written and the version statement was lost. It now defaults to .dbf/reports/<date>-<class>.md, committed with the remediation, and the final message opens with the specification version and source and then the report's location.
  4. The reviewer left a worktree-agent-<id> branch behind, contradicting "changes nothing". isolation: worktree is replaced by a detached worktree the reviewer creates outside the project and removes, pruning first and installing the project's dependencies in it.

Not fixed here: CLAUDE_PLUGIN_DATA is unset in the skill's shell, so the refresh script's cache falls back to ~/.cache. It works; the preference just has no effect from the skill.

Version 0.2.1 in both manifests. Locally: all four claude plugin validate --strict runs, shellcheck, the offline refresh (five vendored documents with an empty cache) and check-spec-version.bash pass.

🤖 Generated with Claude Code

LTSCommerce and others added 2 commits September 30, 2026 10:08
Fixes from an execution test of 0.2.0 on a real defect, run headless:

- The runbook let the independent searcher run in the background whilst
  the rule was written, and nothing said to wait for it, so the original
  was fixed before the search returned, and a headless run emitted its
  final result early. Step 2 now forbids any fix until the findings are
  in hand at step 5, and forbids ending the turn whilst it runs.
- The conformance review ran once; a finding that changed the rule left
  later commits unreviewed. The reviewer is now re-dispatched whenever the
  defence's commits change.
- A project with no records place and no pull request gave the report
  nowhere to go, and the version statement was lost with it. The report
  now goes into the final message in that case, and the final message
  always opens with the specification version and source.
- The reviewer's worktree isolation left a worktree-agent branch in the
  project under review. It now reproduces in a detached worktree of its
  own and removes it, creating no branches.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Independent review of the previous commit:
- "Do not end your turn" is not actionable for a background agent. The
  searcher is now dispatched in the foreground, so its result is in hand
  before the rule is written.
- The report had no default path. It now defaults to
  .dbf/reports/<date>-<class>.md, committed with the remediation, and the
  final message names the location after the version line.
- The reviewer's detached worktree lacks ignored files and could be left
  registered by an interrupted run. It now prunes first and installs the
  project's dependencies in the worktree, or marks the run unverified.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@LTSCommerce
LTSCommerce merged commit b859e75 into main Sep 30, 2026
1 check passed
@LTSCommerce
LTSCommerce deleted the fix/runbook-wait-review-report branch September 30, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant