Repository navigation
Restructure om_vars: download path, catalog cache and Settings - #21
Merged
Merged
Conversation
…nload path in om_vars
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next steps of restructuring
om_varsin place, one menu at a time.themeGenerator,downloadTheme(s),installDownloaded,abortDownload,unpackThemeandgetThemeListgrouped in#### DOWNLOADS. A failed catalog download keeps the current theme list.getThemeListfetches<sys>-list-v2.md5first and skips the download when it matches the local copy. A release must publish the list and its.md5together (build_catalog.sh <sys> --checkin om_themes).#### SETTINGS.toggleFlagreplacessettingsOptionChecker/toggleOptions, andsettingsRowsshows the clean-up and uninstaller rows. The separator now goes tosettings/commands/.INTERNALand run the newom_toggle, so the Theme Manager reloads its list in place instead of relaunching, and the screen no longer flickers.om_themeandom_audioare gone.installdeletes the renamed copy (cNNNN_x↔_x) of every shipped command row, which the previous version's uninstall leaves behind._themeperfolder_1assignis now_themeperfolder_assign.Tested on a SNES console: download path and cancel, catalog cache, the Settings functions in a sandbox (19 cases) and on the live screen. The
installcleanup loop was tested on its own in busybox ash; a full install was not run.