Repository navigation
Fit USA/EUR themes to every region and keep the language binds - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Theme fixes found while testing Console Language and USA/EUR themes on the Super Famicom.
clRebindwhen Console Language provides it, so copyleft stays on the strings (older releases keep the old unmount/mount).themeDepsFix: whendependencies.jsonlists/fonts/{s,m,l}.fontand the firmware has.fnt(or the reverse), a corrected copy is bound over it. The UI exited (C8) on the Super Famicom otherwise.themeColorsFix: a theme can ship its palette asresources/scripts/env/colors_<region>.lua. On a firmware of another region the table name is renamed in the bytecode (same length, patched with od/dd) and the copy is bound over that region's palette, so one palette applies on every region and per-region palettes still win./var/theme_fixes(already a tmpfs at boot) and are unbound before the theme is.fontBindFixcopies every theme font that changed, not only when the title font differs, and reads them from the theme actually chosen (random, default or per-folder) instead of the one baked into b8024.CHANGEME.injectFilewrites it through/bin/chmenuso it applies without a reboot.omSplash,omUnpackandomReloadMenuLaterhelpers (needs Options Menu v2.0.1).Tested on the console (Super Famicom and SNES EUR): Chrono Trigger applies without C8 and with its palette; kanji captions show with the extended theme fonts; language/theme/folder changes keep the language binds and copyleft; DIY preview and clean; the CHANGEME guard leaves state and mounts untouched.