Skip to content

Generate training set#39

Open
zoujiaqi99 wants to merge 5 commits into
masterfrom
generate-training-set
Open

Generate training set#39
zoujiaqi99 wants to merge 5 commits into
masterfrom
generate-training-set

Conversation

@zoujiaqi99

Copy link
Copy Markdown
Collaborator

Hey X,
I open a new PR in order to make the changes more clear.

@zoujiaqi99

Copy link
Copy Markdown
Collaborator Author

I update write_as_tf_file module to TF 2.1 and write a module for reading TFRecord file.
I use def.kernel, def.REST_RANGE to modify spectra_utils.get_lam_data, preprocess.label_sightline, and training_sets. split_sightline_into_samples.
I modify uniform_snr module to use @ZechangSun 's Summary table instead of Mocks object.
After summary table have updated,I will modify uniform_zdla_nhi module.

@profxj profxj left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few requests. Sorry this took so long

@@ -0,0 +1,80 @@
import tensorflow as tf

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a line at the top explaining the purpose of this module.

Split bins for snr_array,zdla_array,nhi_array
-------------------------------------------------------------------------------------
parameters;
data_array:np.ndarray

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add short descriptions for each

Uniform snr in snrrange
Parameter
---------
snr:np.ndarray

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add short descriptions for each


def snr_uniform(snr,ixs,binnum,num,snrrange):
"""
Uniform snr in snrrange

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explain what this method does


def uniform_z_nhi(idarray,z_bins,nhi_bins,num,Mocks):
"""
Uniform zdla,nhi,get sightline id

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explain what this method does

-------------------------------------------------------------------------------
parameters;
idlist:numpy.ndarray
sightlineid array after uniform snr

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

describe the parameters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants