Skip to content

refactor: add entry-point orchestration and StepRunner - #284

Open
marvin1099 wants to merge 3 commits into
rewrite/v2from
marvin1099/rewrite-v2/add-entry-point
Open

refactor: add entry-point orchestration and StepRunner#284
marvin1099 wants to merge 3 commits into
rewrite/v2from
marvin1099/rewrite-v2/add-entry-point

Conversation

@marvin1099

Copy link
Copy Markdown
Collaborator

Revamp entry_point.py with dependency-gated phase orchestration and extract StepRunner into core/runner.py.

  • entry_point.py: main() stripped to pure bootstrap, _run_flow() drives 7 phases with explicit dependency gates and result tracking via settings.internal.main_flow_results.
  • core/runner.py: new StepRunner wrapping settings/log/interface with try_step/try_step_code for guarded execution and try_phase/try_phase_code for higher-level dependency-gated wrappers.

Depends on: #283

@marvin1099
marvin1099 requested a review from shymega July 3, 2026 19:09
gemini-code-assist[bot]

This comment was marked as resolved.

@marvin1099
marvin1099 force-pushed the marvin1099/rewrite-v2/add-entry-point branch 3 times, most recently from 079a92a to 668f8ca Compare July 3, 2026 19:32
@shymega shymega removed the tagets v2 label Jul 3, 2026
@shymega shymega modified the milestone: wand-launcher V2.0.0 Jul 3, 2026
@shymega shymega moved this from Backlog to In progress in `wand-launcher` V2.0.0 Jul 3, 2026
@marvin1099 marvin1099 moved this from In progress to In review in `wand-launcher` V2.0.0 Jul 4, 2026
@marvin1099
marvin1099 force-pushed the marvin1099/rewrite-v2/add-entry-point branch 3 times, most recently from 8e95221 to ca27170 Compare July 4, 2026 09:00
@shymega
shymega force-pushed the marvin1099/rewrite-v2/add-entry-point branch 2 times, most recently from 78273f6 to 857d83c Compare July 4, 2026 10:53
@marvin1099
marvin1099 force-pushed the marvin1099/rewrite-v2/add-entry-point branch from 857d83c to ce8abd1 Compare July 18, 2026 15:56
@marvin1099
marvin1099 force-pushed the marvin1099/rewrite-v2/add-entry-point branch 3 times, most recently from 35d3130 to 7e9e426 Compare July 18, 2026 16:27
Rewrite entrypoint.py from a stub to a full bootstrap that initialises
settings, logging and UI detection, then orchestrates seven action phases
(update, migrations, app install, prefix setup, data sync, monitor launch,
troubleshooter) via a dependency-gated _run_flow().

Add core/runner.py with the StepRunner class providing guarded step
execution (try_step / try_step_code) and higher-level phase wrappers
(try_phase / try_phase_code) with automatic result tracking.

Suppress ty unresolved-import warnings for deferred module imports
that will be implemented in follow-up commits.
@marvin1099
marvin1099 force-pushed the marvin1099/rewrite-v2/add-entry-point branch from 7e9e426 to 4766365 Compare July 18, 2026 16:31

@shymega shymega left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not comfortable with how much is being done in one MR.

We've also had feedback about our usage of AI, and I think we should focus on a policy to try and address this before adding more LLM-generated code.

I'm not against AI, but I fear that that this commit has had little human input, and AI should assist us, not do it all for us.

@marvin1099

Copy link
Copy Markdown
Collaborator Author

I'm not comfortable with how much is being done in one MR.

We've also had feedback about our usage of AI, and I think we should focus on a policy to try and address this before adding more LLM-generated code.

I'm not against AI, but I fear that that this commit has had little human input, and AI should assist us, not do it all for us.

At what point do you feel that way?
Lots of this is boilerplate.
The thing is I know what I like, so the ai I dont think is to far off of what I imagined.
I'm more on Torvalds side here.
I think of AI more of as tool, as long as its human checked.
Now if my goal was more to lean how to make the WeMod launcher I would probably go more manual.
But I know the launcher I just need to put it into a more usable package for devs and users.
So I think I mainly good with this.
So you gona need to be a bit more specific what parts may not align with what you have on mind?

@shymega

shymega commented Aug 5, 2026

Copy link
Copy Markdown
Member

Basically, the main thing I want to see done differently is a laid-out plan, agreed between both of us, before implementation.

That way we're working together, and have a solid agreement on how we want to do this.

I'm not necessarily opposed to this PR in fundamentals, but it changes a lot, and should be done in stages. We could have one PR implementing the StepRunner class, then we could agree on the steps we need. I feel a lot of it needs discussing.

Sorry for the delay on getting back to you. I've been trying to work this out in my head.

@marvin1099

Copy link
Copy Markdown
Collaborator Author

Basically, the main thing I want to see done differently is a laid-out plan, agreed between both of us, before implementation.

Shure.

I'm not necessarily opposed to this PR in fundamentals, but it changes a lot...

I think I have an idea of how you wana do this.
And some more time in the oven of these ideas is probably not bad. Will do more board stuff (possible liked issues) that should work well.

@marvin1099 marvin1099 moved this from In review to Rework in `wand-launcher` V2.0.0 Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Rework

Development

Successfully merging this pull request may close these issues.

2 participants