feat: add source-bound plan review feedback - #18
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
Summary by CodeRabbit
WalkthroughThe PR adds immutable, source-bound ChangesPlan review workflow
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Reviewer
participant CLI
participant PlanFeedback
participant ReviewFile
participant CampaignPlan
Reviewer->>CLI: create plan review
CLI->>PlanFeedback: validate decision and findings
PlanFeedback->>CampaignPlan: bind source and plan identity
PlanFeedback->>ReviewFile: export immutable review
Reviewer->>CLI: verify review
CLI->>PlanFeedback: load and verify review
PlanFeedback->>CampaignPlan: compare current state
PlanFeedback-->>CLI: return validity and blocking status
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/PLAN_FEEDBACK.md`:
- Around line 72-75: Update the exit-code description in the
“--fail-on-blocking” documentation to state that exit 4 also covers invalid
current bound-media state, including missing or changed media, alongside current
plan-state decisions. Preserve the distinction that stale negative decisions
from prior revisions are not blocking.
In `@README.md`:
- Around line 309-311: Update the media-binding documentation in README.md to
clarify that --include-media applies to both plan approval creation and plan
review artifacts, while preserving the existing distinction that positive
authorization remains in the quality-gated plan approval workflow.
In `@samsarix_creative_spirals/cli.py`:
- Line 547: Update the timestamp parsing in the plan review creation flow around
reviewed_at to use the review-specific parser that reports reviewedAt, rather
than parse_approval_timestamp(), while preserving the existing optional-argument
behavior.
In `@samsarix_creative_spirals/plan_feedback.py`:
- Around line 197-200: Update CampaignPlanReview validation at
samsarix_creative_spirals/plan_feedback.py#L197-L200 and
create_campaign_plan_review at
samsarix_creative_spirals/plan_feedback.py#L404-L408 to guard tuple conversion
for non-iterable findings values; catch the conversion failure, append the
validation message to issues, and continue through aggregated ConfigError
handling. Add coverage for findings=None at both public entry points.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 85976204-5ada-4f54-a23c-8756cbe3718c
📒 Files selected for processing (20)
.github/workflows/ci.ymlCHANGELOG.mdREADME.mdROADMAP.mdSECURITY.mddocs/API.mddocs/ARCHITECTURE.mddocs/PLAN_FEEDBACK.mddocs/PLAN_REVIEW.mddocs/QUICKSTART.mdexamples/README.mdsamsarix_creative_spirals/__init__.pysamsarix_creative_spirals/_version.pysamsarix_creative_spirals/cli.pysamsarix_creative_spirals/plan-review.schema.jsonsamsarix_creative_spirals/plan_feedback.pysamsarix_creative_spirals/schema.pytests/test_cli.pytests/test_plan_feedback.pytests/test_public_api.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Trust boundary
Reviewer labels, decisions, hashes, and timestamps are unsigned local metadata. Positive authorization remains in the existing quality-gated plan approval workflow.