Skip to content

Exercise PostgreSQL real-process crash recovery - #24

Merged
Deathcharge merged 2 commits into
mainfrom
codex/postgres-subprocess-gates-v0.13
Aug 11, 2026
Merged

Exercise PostgreSQL real-process crash recovery#24
Deathcharge merged 2 commits into
mainfrom
codex/postgres-subprocess-gates-v0.13

Conversation

@Deathcharge

@Deathcharge Deathcharge commented Aug 11, 2026

Copy link
Copy Markdown
Owner

Summary

Adds the first real OS-process acceptance gate for the guarded PostgreSQL v0.13 preview and fixes the cross-instance handshake-ordering race that the gate exposed.

Included

  • launches two independent Samsarix CLI/Uvicorn processes against one PostgreSQL database
  • verifies shared HTTP state and cross-process WebSocket presence/messages over real TCP sockets
  • kills one process without graceful cleanup and observes lease-derived presence.left plus deployment capacity convergence
  • restarts the same stable replica identity after lease expiry and verifies durable history recovery
  • keeps newly registered sockets broadcast-inactive until their mandatory ready and history frames succeed, preventing remote relay events from overtaking initialization
  • bounds PostgreSQL/quality CI jobs and their individual tests
  • updates preview, roadmap, changelog, and architecture evidence without making a production-support claim

Verification

GitHub Actions run 31462565043 is fully green:

  • PostgreSQL 18 integration, including the real-process crash/restart gate: pass
  • full quality/coverage/package/audit suite: pass
  • Python 3.10 through 3.14 and Windows 3.12: pass
  • TypeScript client and hardened container image: pass

Local verification passed Ruff, mypy, 144 non-PostgreSQL tests, and focused connection-manager/WebSocket suites. Local live PostgreSQL execution was unavailable because this workstation has neither PostgreSQL nor Docker; the same test passed in both dedicated PostgreSQL CI and the full quality job.

Remaining preview gates

Forced database/listener interruption, update/delete process delivery, archive/ban teardown across processes, explicit reconnect recovery, reconnect storms, sustained load/soak, deployment manifests, and exercised PostgreSQL backup/PITR/rollback remain before production multi-instance support.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Deathcharge, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 27 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: de7e823b-3d32-418f-90b8-8ae9832c5f58

📥 Commits

Reviewing files that changed from the base of the PR and between 9960ec9 and b2a7bce.

📒 Files selected for processing (9)
  • .github/workflows/ci.yml
  • CHANGELOG.md
  • ROADMAP.md
  • docs/MULTI_INSTANCE_ARCHITECTURE.md
  • docs/POSTGRES_PREVIEW.md
  • samsarix_chat_engine/app.py
  • samsarix_chat_engine/websocket_manager.py
  • tests/test_connection_manager.py
  • tests/test_postgres_processes.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Deathcharge
Deathcharge marked this pull request as ready for review August 11, 2026 05:46
@Deathcharge
Deathcharge merged commit 4c15537 into main Aug 11, 2026
11 checks passed
@Deathcharge
Deathcharge deleted the codex/postgres-subprocess-gates-v0.13 branch August 11, 2026 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant