Evaluate the bounded standalone agent runtime - #4
Merged
Conversation
|
Important Review skippedToo many files! This PR contains 188 files, which is 88 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (188)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deathcharge
marked this pull request as ready for review
August 13, 2026 07:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Expose and review a bounded OpenAI-compatible session/provider client. This PR does not make Agent Engine the canonical Samsarix controlled runtime and does not authorize publication.
Supported boundary
What changed
agents/andservices/application snapshots so this repository represents only the standalone packagetool-Ncorrelation IDs and registered local names orunavailableSnapshot evidence and recovery
c709e2b444a21fc7eaaa9ef8afaf5f1cea4b040a3b3961d4ec1416f19e5f102d865d5664f43e27a9799c0f07862a4f0e922a9c67f3f3e6f697d2d5c0archive/pre-agent-engine-snapshot-removal-20260810docs/REMOVED_SNAPSHOT_FILES.mddocs/SNAPSHOT_DISPOSITION.mdThe removal is not an installable-package/API regression: packaging discovered only
src/samsarix_agent_engine*, both pre-deletion wheel and sdist contained zero snapshot entries, and supported source/tests/examples did not import the top-level trees. It intentionally breaks an undocumented checkout-only import path whose modules resolve privateapps.backend.*code from another checkout and rely on a large undeclared application stack.Security review
The initial full PR diff scan found one low-severity audit-metadata issue: a malicious provider could place selected tool names/call IDs into otherwise content-free local events. Exact package-API probes reproduced success, denied, and unavailable-tool paths. The current head fixes the issue without changing provider correlation or approval binding.
A separate clean-room remediation scan reviewed every changed source file in full and found no remaining candidate. Focused reviewers confirmed sequential ordering and all request, round, call, argument, and result budgets remain intact.
Verification
Local exact-head verification:
agents/orservices/snapshot entriesHosted exact-head Python 3.11–3.14, dependency audit, package, and status checks are green. Merge remains distinct from release or adoption; a real consumer compatibility fixture is still required before publication.