Skip to content

fix: skip non-APIRoute entries (Starlette >=1.3.1 compatibility) #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dajiaohuang wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Open

fix: skip non-APIRoute entries (Starlette >=1.3.1 compatibility) #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion fastapi_versioning/versioning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,10 @@ def VersionedFastAPI(
version_route_mapping: Dict[Tuple[int, int], List[APIRoute]] = defaultdict(
list
)
# Filter out non-APIRoute entries (e.g. _IncludedRouter from Starlette >=1.3.1)
api_routes = [r for r in app.routes if isinstance(r, APIRoute)]
version_routes = [
version_to_route(route, default_version) for route in app.routes
version_to_route(route, default_version) for route in api_routes
]

for version, route in version_routes:
Expand Down