fix: point sandbox environment to the single API host#12
Merged
Conversation
The OpenAPI spec defines a single host (https://developers.dealermax.app) for both production and sandbox, with traffic routed by the API key prefix (pmk_live_* vs pmk_sand_*). The SDK's `sandbox` environment instead targeted https://sandbox.developers.dealermax.app, which does not resolve (NXDOMAIN), so any partner using `environment="sandbox"` — including the first example in the README — hit an unrecoverable APIConnectionError. Point sandbox at the same host so the key prefix performs the routing, as the contract intends. Also refresh the stale self-version in uv.lock (0.0.1 -> 0.10.0). https://claude.ai/code/session_016dVWauAWAvgrctxxjCQLVV
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit severo dell'SDK — esito
Audit completo dell'SDK Python
partnermaxv0.10.0 in vista della proposta a nuovi Partner. Sintesi: l'SDK è solido e allineato allo spec, con un bug critico di onboarding corretto in questa PR.Verifiche superate
import partnermaxuv build(wheel + sdist)_version.py/pyproject/ manifest / CHANGELOG)PermissionDeniedError)I 21 endpoint dell'SDK coincidono 1:1 con i 21 path dello spec; gli schemi di sicurezza (
X-Api-Key+Bearer) corrispondono.Bug critico corretto
Lo spec OpenAPI dichiara esplicitamente un host unico con routing deciso dal prefisso della key:
L'SDK invece puntava l'environment
sandboxahttps://sandbox.developers.dealermax.app, che non risolve (NXDOMAIN). Qualunque Partner usasseenvironment="sandbox"— incluso il primo esempio del README — otteneva unAPIConnectionErrorirreversibile (Name or service not known). Riprodotto e verificato.Fix:
sandboxora punta allo stesso hosthttps://developers.dealermax.app, lasciando che sia il prefisso della key a instradare, come previsto dal contratto. Verificato: dopo la fixenvironment="sandbox"raggiunge l'host reale e riceve risposte HTTP strutturate.Incluso anche l'allineamento della self-version stale in
uv.lock(0.0.1→0.10.0).Osservazioni minori (non bloccanti)
examples/contiene solo.keep— il README ha però esempi inline completi (sync, async, aiohttp, upload file, gestione errori, retry, timeout).Test plan
environment="sandbox"raggiunge l'host dopo la fixhttps://claude.ai/code/session_016dVWauAWAvgrctxxjCQLVV
Generated by Claude Code