Fix sidebar Space disclosure markers#308
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Change Scope
📝 What Does This PR Do?
Fixes the sidebar Space affordance so expandability and rail identity are represented separately.
The previous implementation reused the disclosure icon for every Space. Empty Spaces therefore displayed a left-side arrow even though they had no child agents to expand, while removing that arrow wholesale made expandable Spaces ambiguous in the collapsed rail.
This PR:
aria-expandedsemantics from empty Spaces;🏗️ Large Change Spec (Required if "Large Change" is checked)
Not applicable — this is a localized Small Change with no new mutable state, persistence, IPC, or lifecycle behavior.
1. Context & Business Logic
A Space with agents is expandable and keeps a chevron. An empty Space is a leaf and gets only a passive rail marker.
2. State Ownership & Invariants
Rendering remains derived from the existing renderer-owned agent list.
aria-expanded.3. Verification Plan & Regression Layer
Component tests lock down accessibility semantics. Electron E2E tests lock down geometry, themes, responsive sidebar modes, and transition behavior. The complete repository pre-commit gate passed.
✅ Delivery & Compliance Checklist
pnpm pre-commitis completely green.DEVELOPMENT.mdarchitectural boundaries.📸 Screenshots / Visual Evidence
Playwright visual evidence was generated for light/dark themes and rail/peek/docked states. GitHub's browser upload surface was unavailable in this run, so the review-only contact sheet remains ready for manual attachment and is intentionally not committed to the repository.