Refine contextual Project and Space popovers#307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Change Scope
📝 What Does This PR Do?
Refines Project and Space operation UI into compact, anchored contextual popovers.
maindismissable-layer primitives while preserving transient parent ownership for nested portaled selectors.🏗️ Large Change Spec (Required if "Large Change" is checked)
1. Context & Business Logic
Project and Space actions previously used app-level modal windows with inconsistent geometry and blocking behavior. The new behavior follows contextual menu semantics before confirmation, then switches only the target Space into a local running state after confirmation.
The recovery E2E previously treated disappearance of the editor as operation completion. With asynchronous local progress, that could race the Git operation and feed a stale source path into destructive cleanup. The fixture now owns an isolated temporary repository and waits for the durable Space directory transition before continuing.
2. State Ownership & Invariants
git worktree list --porcelain -z.3. Verification Plan & Regression Layer
pnpm pre-commit: exit 0; staged Vitest 240 files passed / 3 skipped (868 tests passed / 3 skipped), native Electron terminal recovery 3/3 passed, and Electron E2E 262 passed / 47 conditionally skipped with zero retries.node_modules, and clean Git status remained intact.✅ Delivery & Compliance Checklist
pnpm pre-commitis completely green.CLA.md).DEVELOPMENT.mdarchitectural boundaries.📸 Screenshots / Visual Evidence
Visual artifacts were captured locally for dark theme, light theme, the expanded branch list, and the opening motion. They can be attached to this draft during review.