Skip to content

chore: Fix Svelte stats fallback and pnpm tooling#117

Merged
stefashkaa merged 3 commits into
mainfrom
chore/fix-readme-benchmarks
Jun 23, 2026
Merged

chore: Fix Svelte stats fallback and pnpm tooling#117
stefashkaa merged 3 commits into
mainfrom
chore/fix-readme-benchmarks

Conversation

@stefashkaa

@stefashkaa stefashkaa commented Jun 23, 2026

Copy link
Copy Markdown
Member

Description

  • What does this PR do?

    • Fixes the stable package stats script for Svelte package benchmark/readme generation by updating the fallback Svelte version to ^5.56.4.
    • Upgrades pnpm from 11.6.0 to 11.9.0 in package.json and GitHub workflows.
    • Updates clean scripts so the root clean command includes the demo workspace and the demo clean command removes Nuxt output directories.
  • Why is this change needed?

    • The Svelte fallback version avoids temp build issues where TypeScript syntax remains untransformed in some node_modules .svelte files.
    • CI and release workflows should use the same pnpm version declared by the workspace.
    • Demo cleanup should remove actual Nuxt generated directories and be included in workspace-level cleanup.

Type of Change

  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change
  • Documentation update
  • Tests
  • Other (describe below): Tooling and maintenance updates

Testing

  • pnpm clean
  • pnpm build
  • pnpm test:unit

Screenshots (if applicable)

N/A

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Comments added for complex code
  • Documentation updated
  • No new warnings generated
  • Tests added/updated
  • All tests passing

Manual Coverage (Optional)

Run Coverage Workflow

Maintainers only (write/maintain/admin access): open the workflow, click Run workflow, and set pr_number to this PR number to post/update a coverage comment on this PR

Summary by CodeRabbit

  • Chores
    • Upgraded package manager (pnpm) from v11.6.0 to v11.9.0 across all build workflows including coverage, release, weekly benchmarks, and code generation pipelines
    • Updated build script configurations and development environment dependency versions

Copilot AI review requested due to automatic review settings June 23, 2026 23:39
@vercel

vercel Bot commented Jun 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
phone-mask Ready Ready Preview, Comment Jun 23, 2026 11:39pm

Request Review

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2da46155-94fe-46f9-9e83-979821add4dc

📥 Commits

Reviewing files that changed from the base of the PR and between 1cf90b6 and fbe93e8.

📒 Files selected for processing (7)
  • .github/workflows/coverage.yml
  • .github/workflows/release.yml
  • .github/workflows/weekly-benchmarks.yml
  • .github/workflows/weekly-gen.yml
  • demo/package.json
  • package.json
  • scripts/stable-package-stats.mts

📝 Walkthrough

Walkthrough

pnpm is bumped from 11.6.0 to 11.9.0 in four CI workflow files and the root package.json packageManager field. The root clean script filter is broadened to all workspace packages, the demo clean script now targets Nuxt output directories, and the Svelte benchmark fallback version is pinned to ^5.56.4.

Changes

Tooling and config updates

Layer / File(s) Summary
pnpm 11.9.0 version pin
package.json, .github/workflows/coverage.yml, .github/workflows/release.yml, .github/workflows/weekly-benchmarks.yml, .github/workflows/weekly-gen.yml
packageManager field and all four "Setup pnpm" workflow steps are updated from 11.6.0 to 11.9.0.
Clean script and Svelte fallback update
package.json, demo/package.json, scripts/stable-package-stats.mts
Root clean script filter broadened from ./packages/** to *; demo clean script changed to remove .output and .nuxt instead of dist; SVELTE_FALLBACK_SVELTE_VERSION pinned to ^5.56.4 with an inline comment.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • DeSource-Labs/phone-mask#84: Also bumps pnpm version in workflow "Setup pnpm" steps and the root package.json packageManager field, targeting the same configuration points.
  • DeSource-Labs/phone-mask#113: Touches the same pnpm wiring in root package.json and GitHub Actions workflow setup steps.
  • DeSource-Labs/phone-mask#91: Directly modifies scripts/stable-package-stats.mts, the same file where SVELTE_FALLBACK_SVELTE_VERSION is updated in this PR.

Poem

🐇 Hop, hop — the pnpm clock ticks new,
From eleven-six-oh to nine we flew!
Clean scripts now sweep .nuxt and .output away,
Svelte's fallback version locked in today.
With every bump the warren runs bright,
A tidy monorepo — pure delight! 🌟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: fixing Svelte stats fallback and upgrading pnpm tooling, which align with the PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/fix-readme-benchmarks

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns tooling and cleanup behavior across the workspace, and stabilizes the Svelte fallback used by the package stats script to avoid temporary-build issues during benchmark/README generation.

Changes:

  • Update the Svelte fallback version in stable-package-stats to ^5.56.4 with an explanatory note.
  • Bump the repo’s pnpm version from 11.6.0 to 11.9.0 in package.json and CI/release workflows.
  • Improve cleanup scripts by including the demo workspace in the root clean and removing Nuxt output directories in demo’s clean.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
scripts/stable-package-stats.mts Updates the Svelte fallback version used for temp Vite builds when measuring Svelte-only exports.
package.json Bumps packageManager pnpm version and expands root clean to run across all workspaces (including demo).
demo/package.json Adjusts clean to remove Nuxt-generated output directories (.output, .nuxt).
.github/workflows/weekly-gen.yml Updates workflow pnpm version to match the workspace packageManager.
.github/workflows/weekly-benchmarks.yml Updates workflow pnpm version to match the workspace packageManager.
.github/workflows/release.yml Updates workflow pnpm version to match the workspace packageManager.
.github/workflows/coverage.yml Updates workflow pnpm version to match the workspace packageManager.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@stefashkaa
stefashkaa merged commit b9f45c2 into main Jun 23, 2026
7 checks passed
@sonarqubecloud

Copy link
Copy Markdown

@stefashkaa
stefashkaa deleted the chore/fix-readme-benchmarks branch June 23, 2026 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants