Skip to content

fix #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavAug merged 3 commits into from
May 23, 2026
Merged

fix #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
690dae3
fix
DavAug May 23, 2026
9225995
update copyright
DavAug May 23, 2026
d017170
Introduce upper limit for arviz until caught up with changes
DavAug May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion LICENSE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
BSD 3-Clause License

Copyright (c) 2025, David Augustin
Copyright (c) 2026, David Augustin
All rights reserved.

Redistribution and use in source and binary forms, with or without
Expand Down
2 changes: 1 addition & 1 deletion chi/_problems.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ def _extract_covariates(self, covariate_names):
for idn, _id in enumerate(self._ids):
mask = temp[self._id_key] == _id
covariates[idn, idc] = \
temp.loc[mask, self._value_key].dropna().values
temp.loc[mask, self._value_key].dropna().values.squeeze()

return covariates

Expand Down
4 changes: 2 additions & 2 deletions chi/plots/_residuals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,11 @@ def _add_predicted_versus_observed_scatter_plot(

if show_residuals is True:
# Compute residuals of observations from mean predictions
observations -= mean_predictions
observations = observations - mean_predictions

if show_relative is True:
# Normalise observations by mean predictions
observations /= mean_predictions
observations = observations / mean_predictions

# Plot mean predictions versus observations
color = colors[index % n_colors]
Expand Down
2 changes: 1 addition & 1 deletion chi/tests/test_inference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,7 +783,7 @@ def test_run(self):
self.assertEqual(ids[5], str(self.ids[5]))
self.assertEqual(ids[6], str(self.ids[6]))
self.assertEqual(ids[7], str(self.ids[7]))
self.assertIsNone(ids[8])
self.assertTrue(np.isnan(ids[8]).all())

parameters = result['Parameter'].unique()
self.assertEqual(len(parameters), 16)
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ classifiers = [
]

dependencies = [
'arviz>=0.17',
'arviz>=0.17, <=0.23.4',
'myokit>=1.34',
'numpy>=1.17',
'pandas>=0.24',
Expand Down
Loading