Repository navigation
Revisión de bloque del 1-nov: cierre de la sesión de vista previa sin carreras y mapeo único de calidad y dispositivo - #5
Merged
Conversation
…es de ejecutar y al abrir otro video, sin carreras al soltar «Después»; calidad y dispositivo se mapean en ToolParameters Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Dathinel
added a commit
that referenced
this pull request
Nov 1, 2026
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué cambia
Los arreglos de la revisión de bloque de agy sobre #4 (hechos por agy en worktree, revisados y probados por Claude):
Rodaje.Module.Vision.exea la vez). AhoraOnEjecutarClickesperaClosePreviewSessionAsync()antes de empezar y, al terminar, si «Después» sigue pulsado, vuelve a refrescar la vista previa.RefreshPreviewAsynclanzaba el cierre sin esperarlo; ahora el cierre es un solo punto (ClosePreviewSessionAsynccancela la máscara en vuelo, desecha la sesión y la pone a null) y se espera antes de seguir. PruebaDisposeAsync_mientras_hay_llamada_en_vuelo_no_rompe_la_llamada_siguienteenVistaPreviaTests.ToolParameters.QualityFromIndexyDeviceFromIndexsustituyen a las dos expresiones repetidas entre la vista previa y la ejecución. PruebaToolParametersTests.Cómo se probó
build\dotnet.cmd build src\Rastrear.slnx -c Debug -warnaserror: 0 advertencias.tests\Rastrear.Tests: 57 pruebas en verde (eran 54). Lo que solo se ve con la ventana (alternar «Después» mientras se ejecuta, abrir otro video con la vista previa activa) queda para el bloque 10 dedocs/pruebas-a-mano.md.🤖 Generated with Claude Code