Skip to content

Show full revenue amount in platform dashboard - #75

Merged
BeforeLights merged 1 commit into
mainfrom
codex/platform-admin-full-revenue
Aug 21, 2026
Merged

BeforeLights merged 1 commit into
mainfrom
codex/platform-admin-full-revenue

Conversation

@BeforeLights

@BeforeLights BeforeLights commented Aug 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • render the full settled VND amount in the primary KPI
  • render the full settled VND amount above the revenue chart
  • keep compact formatting only on chart axes

Verification

  • RED: focused test observed compact 3,1 Tr ₫
  • GREEN: corepack pnpm --filter @databreeze/web exec vitest run test/platform-admin-feedbacks.test.tsx (12/12)
  • Web typecheck
  • scoped ESLint and Prettier
  • git diff --check

Summary by CodeRabbit

  • Bug Fixes

    • Platform revenue amounts now display the complete currency value instead of abbreviated notation.
    • Revenue totals are shown consistently in overview summaries and chart headings.
  • Tests

    • Added coverage to verify that full settled revenue amounts render correctly.

@BeforeLights
BeforeLights merged commit 98bb2aa into main Aug 21, 2026
4 of 5 checks passed
@coderabbitai

coderabbitai Bot commented Aug 21, 2026 •

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 38e3dffe-8d32-46a7-9dc4-1dbf53e5d127

📥 Commits

Reviewing files that changed from the base of the PR and between 209a2cc and 01ee9ed.

📒 Files selected for processing (2)
  • apps/web/src/features/platform-admin/platform-admin-page.tsx
  • apps/web/test/platform-admin-feedbacks.test.tsx

📝 Walkthrough

Walkthrough

The platform-admin overview now shows full VND amounts for settled revenue in the KPI and revenue chart heading. Tests can provide custom overview data and verify the complete formatted amount.

Changes

Platform admin revenue display

Layer / File(s) Summary
Full revenue formatting
apps/web/src/features/platform-admin/platform-admin-page.tsx
The compact formatter was removed. The settled revenue KPI and chart heading now use the full VND formatter.
Revenue formatting coverage
apps/web/test/platform-admin-feedbacks.test.tsx
The server stub accepts custom overview data. A test verifies that 3_129_000 renders in full format in both overview displays.

Estimated code review effort: 2 (Simple) | ~10 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/platform-admin-full-revenue

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Aug 21, 2026

Copy link
Copy Markdown

Greptile Summary

The PR replaces compact VND formatting with full currency amounts in the platform dashboard’s revenue summaries while retaining compact chart-axis labels.

  • Removes the compact currency formatter from the platform-admin page.
  • Uses locale-aware full currency formatting for the primary revenue KPI and chart heading.
  • Adds a focused test asserting both Vietnamese full-value displays.

Confidence Score: 4/5

The PR appears safe to merge, with a non-blocking responsive-layout concern for large revenue totals.

The formatting change correctly renders full VND totals and is covered by a focused test, but long values lack wrapping or overflow treatment in the KPI and chart-header layouts.

Files Needing Attention: apps/web/src/features/platform-admin/platform-admin-page.tsx

Important Files Changed

Filename Overview
apps/web/src/features/platform-admin/platform-admin-page.tsx Replaces compact revenue summaries with full VND values, but the affected responsive containers do not accommodate long totals.
apps/web/test/platform-admin-feedbacks.test.tsx Extends the server stub to accept overview fixtures and verifies both intended full-value revenue displays.

Reviews (1): Last reviewed commit: "fix(web): show full platform revenue" | Re-trigger Greptile

@@ -965,7 +955,7 @@ export function PlatformAdminRoutePage() {
{[

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Full amounts lack responsive handling

Large settled VND totals now produce long strings in the primary KPI and chart header, while both value containers lack wrapping or overflow treatment. On narrow dashboard viewports, this increases card height or wraps the values awkwardly, reducing the legibility of the revenue summaries.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant