feat(t3-1): verified_sources.json — 40-entry dlt source manifest - #191
Open
JesuFemi-O wants to merge 4 commits into
Open
feat(t3-1): verified_sources.json — 40-entry dlt source manifest#191JesuFemi-O wants to merge 4 commits into
JesuFemi-O wants to merge 4 commits into
Conversation
…entries Full credential/config metadata for 8 catalog sources (github, slack, stripe, hubspot, notion, google_sheets, rest_api, filesystem). Baseline entries for 32 additional dlt verified sources. rest_api, filesystem, and sql_database marked requires_dlt_init=false (built-in to dlt). Closes #98
…s_dlt_init false - asana: dlt_init_name 'asana' -> 'asana_dlt' (correct dlt verified source name) - confluence, hackernews, linkedin_ads, piano, postgres, sendgrid, twilio, twitter, chargebee, google_cloud_storage, dremio: set requires_dlt_init=false and dlt_init_name=null — their dlt init names are unverified; marking false prevents users from running dlt init <wrong-name> and silently getting a generic template instead of a real source connector
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Move dlt_source, dlt_init_name, requires_dlt_init into a backend object and add provider: "dlt" on every entry. This keeps SourceSpec generic — adding Airbyte, Fivetran, or Estuary means a new provider value and a different backend shape, with no changes to the shared model fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/tycoon/ingestion/data/verified_sources.jsonwith 40+ dlt source entriesrequires_dlt_init: falsefor rest_api, sql_database, filesystem (built-in to dlt) and for 11 entries whose dlt init names could not be verified against https://github.com/dlt-hub/verified-sourcesdlt_init_name: "asana_dlt"(correct) rather than "asana";"shopify_dlt"(correct) for shopifyTest plan
uv run pytest tests/test_manifest.py— all 17 passpython -c "from tycoon.ingestion.manifest import load_manifest; m = load_manifest(); print(len(m))"outputs ≥ 40Closes #98
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.