-
Notifications
You must be signed in to change notification settings - Fork 0
feat(project): add migrate_project and SCHEMA_VERSION (M2 T2-2) #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
718e6aa
feat(project): add migrate_project and SCHEMA_VERSION (M2 T2-2)
JesuFemi-O 57fa848
fix(migrate_project): consolidate MetadataConfig defaults, guard vers…
JesuFemi-O 748e916
fix(migrate_project): use ruamel.yaml to preserve comments, add schem…
JesuFemi-O 54b58a5
fix(schema_version): switch to integer, validate type, error on futur…
JesuFemi-O File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the substantive one. Three changes rolled together:
Three outcomes instead of two. Today a file written by a newer tycoon falls through and returns
False, which the caller reads as "already up to date" — so the CLI proceeds against a schema this build doesn't understand. That's the safety gap that worries me more than the downgrade bug. Older → migrate; equal → no-op; newer → refuse loudly.A step chain instead of inline
ifblocks. Right now migrate does exactly one thing, butSCHEMA_VERSIONexists precisely because there will be more, and step two must run only for files below it. Adding v3 then becomes writing_to_v3and bumping the constant, with no change to the driver.raw.get("schema_version", 1)treats an unstamped file as v1, so existing projects flow through the same path rather than needing aNonebranch.isinstance(current, bool)comes first becauseboolsubclassesint, soschema_version: truewould otherwise sail through.ProjectMigrationErrorsubclassesRuntimeErrorto matchIngestionError/ScheduleError; the command layer catches it and turns it intoerror(...)+typer.Exit(1).