chore: pin erpl-proto to v2026.9.2.1 and empty the known-failure list - #142
Merged
Conversation
The pin has been held at v2026.8.29.1 because every newer release traded one defect for another: v2026.9.2 fixed the table-delta padding gap (sap_rfc_struct_layout) but regressed BICS from 45/45 to 23/45 on a nested-TTYP basXML defect, and the release before it broke ODP outright. Both are fixed upstream (erpl-proto#60, #61), so rfc/test/proto_known_failures.txt is now EMPTY -- the runner treats a listed test that passes as a failure, so this is asserted, not assumed. Verified against the live system at this pin, on top of the three scan-path fixes merged today: RFC 34/34 0 failures, 0 known gaps ODP 25/25 0 failures, 0 known gaps BICS 45/45 0 failures, 0 known gaps First time the proto backend passes every suite with nothing recorded as a gap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pin sat at
v2026.8.29.1because every newer release traded one defect for another:v2026.9.2fixed the table-delta padding gap (sap_rfc_struct_layout) but regressed BICS from 45/45 to 23/45 on a nested-TTYPbasXML defect, and the release before it broke ODP outright.Both are fixed upstream (DataZooDE/erpl-proto#60, #61), so
rfc/test/proto_known_failures.txtis now empty. That is an assertion, not a formality — the runner fails the run if a listed test passes, so an empty list means the suite is strict.Verified live at this pin, on top of the three scan-path fixes merged today:
First time the proto backend passes every suite with nothing recorded as a gap.
Also drops the
v2026.09.02changelog paragraph that explained why the pin was held back — it no longer describes reality.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.