Skip to content

build: make the ODP real-change delta tests runnable - #130

Merged
jrosskopf merged 1 commit into
masterfrom
claude/odp-delta-harness-target
Aug 31, 2026
Merged

build: make the ODP real-change delta tests runnable#130
jrosskopf merged 1 commit into
masterfrom
claude/odp-delta-harness-target

Conversation

@jrosskopf

@jrosskopf jrosskopf commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

odp/test/harness/run_delta_tests.sh was wired into nothing — not the Makefile, not
CI, not any script. grep -r run_delta_tests matches only the file itself.

That matters because it is the only delta coverage in the repo that proves anything.
Every delta test in odp/test/sql runs against 0D_FC_C01$F, a static fact cube
that never changes, so they can assert at most "a second call returns nothing". The
harness writes rows through a CDS view and asserts the actual values that come back —
VAL, REV, ODQ_CHANGEMODE — across insert, update, delete, mixed and bulk
scenarios.

Adds two targets:

make delta_fixtures_odp   # deploy the ABAP fixtures, once per fresh system
make delta_tests_odp      # run the real-change scenarios

Deliberately not folded into sql_tests_odp: the harness mutates the SAP system,
so it cannot run unattended beside the other suites on a shared trial.

Found while auditing the ODP suite for assertion rigour (see DataZooDE/erpl-odp#8,
which fixes 17 assertions that could not fail).


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

odp/test/harness/run_delta_tests.sh was wired into nothing -- not the Makefile, not
CI, not any script. `grep -r run_delta_tests` matched only the file itself.

That matters because it is the only delta coverage in the repo that proves anything.
Every delta test in odp/test/sql runs against 0D_FC_C01$F, a static fact cube that
never changes, so they can assert at most "a second call returns nothing". The
harness writes rows through a CDS view and asserts the actual values that come back
(VAL, REV, ODQ_CHANGEMODE) across insert, update, delete, mixed and bulk scenarios.

Deliberately NOT folded into sql_tests_odp: the harness MUTATES the SAP system, so it
cannot run unattended beside the other suites on a shared trial. Run
delta_fixtures_odp once per fresh system, then delta_tests_odp as often as needed.
@jrosskopf
jrosskopf merged commit e49c140 into master Aug 31, 2026
53 checks passed
@jrosskopf
jrosskopf deleted the claude/odp-delta-harness-target branch August 31, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant