build: make the ODP real-change delta tests runnable - #130
Merged
Conversation
odp/test/harness/run_delta_tests.sh was wired into nothing -- not the Makefile, not CI, not any script. `grep -r run_delta_tests` matched only the file itself. That matters because it is the only delta coverage in the repo that proves anything. Every delta test in odp/test/sql runs against 0D_FC_C01$F, a static fact cube that never changes, so they can assert at most "a second call returns nothing". The harness writes rows through a CDS view and asserts the actual values that come back (VAL, REV, ODQ_CHANGEMODE) across insert, update, delete, mixed and bulk scenarios. Deliberately NOT folded into sql_tests_odp: the harness MUTATES the SAP system, so it cannot run unattended beside the other suites on a shared trial. Run delta_fixtures_odp once per fresh system, then delta_tests_odp as often as needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
odp/test/harness/run_delta_tests.shwas wired into nothing — not the Makefile, notCI, not any script.
grep -r run_delta_testsmatches only the file itself.That matters because it is the only delta coverage in the repo that proves anything.
Every delta test in
odp/test/sqlruns against0D_FC_C01$F, a static fact cubethat never changes, so they can assert at most "a second call returns nothing". The
harness writes rows through a CDS view and asserts the actual values that come back —
VAL,REV,ODQ_CHANGEMODE— across insert, update, delete, mixed and bulkscenarios.
Adds two targets:
Deliberately not folded into
sql_tests_odp: the harness mutates the SAP system,so it cannot run unattended beside the other suites on a shared trial.
Found while auditing the ODP suite for assertion rigour (see DataZooDE/erpl-odp#8,
which fixes 17 assertions that could not fail).
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.