fix(ci): match excluded archs exactly so Windows is really smoke tested - #10
Merged
Conversation
The gate used a substring test against exclude_archs. This repo excludes `windows_amd64_mingw`, which also matches `windows_amd64` -- so the Windows smoke job printed "excluded by the build job" and reported success without ever downloading, loading or exercising the artifact. Green meant nothing ran, which is precisely what this workflow exists to prevent. Split the list on `;`/`,`/whitespace and compare whole tokens instead. The list is passed via env because some callers set exclude_archs from a GitHub expression whose value contains quotes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The smoke-test gate used a substring test against
exclude_archs. This repo excludeswindows_amd64_mingw, which also matcheswindows_amd64— so the Windows smoke job printed "excluded by the build job" and reported success without ever downloading, loading or exercising the artifact.Green meant nothing ran, which is exactly what this workflow exists to prevent. Found when anofox-scenario's Linux and macOS smoke jobs failed on a real artifact-name bug while its Windows job "passed".
Split the list on
;/,/whitespace and compare whole tokens instead. The list now goes throughenv:because some callers setexclude_archsfrom a GitHub expression whose value contains quotes.Verify: the Windows smoke job in this PR must actually run the three steps, not print "is excluded".
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.