fix: max values fix

Author: KilianTrunk

resources/lang/en/property.php

@@ -34,7 +34,7 @@
         'code' => 'Optional alphanumeric code with underscores, automatically converted to lowercase',
         'internal_name' => 'Internal name for distinction, not translatable',
         'is_global' => 'Auto-assigned to all product types',
-        'max_values' => 'Controls form field type: single = radio/select, multiple = checkbox/multiselect',
+        'max_values' => 'Maximum number of values allowed for this property (1 = single value, 2+ = multiple values)',
         'enable_sorting' => 'Allow drag-and-drop sorting of property values',
         'is_filter' => 'Display property as filter in product table',
         'product_types' => 'Select product types for this property (ignored if Global is enabled)',
@@ -66,19 +66,7 @@
         ],
     ],
 
-    'options' => [
-        'max_values' => [
-            1 => 'Single value (1)',
-            2 => 'Multiple values (2+)',
-        ],
-    ],
 
-    'format' => [
-        'max_values' => [
-            'single' => 'Single',
-            'multiple' => 'Multiple',
-        ],
-    ],
 
     'messages' => [
         'created' => 'Property created successfully.',

resources/lang/sl/property.php

@@ -34,7 +34,7 @@
         'code' => 'Neobvezna alfanumerična koda s podčrtaji, avtomatsko pretvorjena v male črke',
         'internal_name' => 'Interno ime za razlikovanje, ni prevedeno',
         'is_global' => 'Avtomatsko dodeljeno vsem tipom proizvodov',
-        'max_values' => 'Nadzoruje tip polja obrazca: ena = radio/select, več = checkbox/multiselect',
+        'max_values' => 'Največje število vrednosti, ki so dovoljene za to lastnost (1 = ena vrednost, 2+ = več vrednosti)',
         'enable_sorting' => 'Dovoli razvrščanje vrednosti lastnosti z vlečenjem',
         'is_filter' => 'Prikaži lastnost kot filter v tabeli proizvodov',
         'product_types' => 'Izberi tipe proizvodov za to lastnost (ignorirano, če je Global omogočeno)',
@@ -66,19 +66,7 @@
         ],
     ],
 
-    'options' => [
-        'max_values' => [
-            1 => 'Ena vrednost (1)',
-            2 => 'Več vrednosti (2+)',
-        ],
-    ],
 
-    'format' => [
-        'max_values' => [
-            'single' => 'Ena',
-            'multiple' => 'Več',
-        ],
-    ],
 
     'messages' => [
         'created' => 'Lastnost je bila uspešno ustvarjena.',

src/Filament/Resources/PropertyResource.php

@@ -62,12 +62,11 @@ public static function form(Form $form): Form
                             ->helperText(__('eclipse-catalogue::property.help_text.is_global'))
                             ->reactive(),
 
-                        Forms\Components\Select::make('max_values')
+                        Forms\Components\TextInput::make('max_values')
                             ->label(__('eclipse-catalogue::property.fields.max_values'))
-                            ->options([
-                                1 => __('eclipse-catalogue::property.options.max_values.1'),
-                                2 => __('eclipse-catalogue::property.options.max_values.2'),
-                            ])
+                            ->numeric()
+                            ->minValue(1)
+                            ->maxValue(10)
                             ->helperText(__('eclipse-catalogue::property.help_text.max_values')),
 
                         Forms\Components\Toggle::make('enable_sorting')
@@ -117,7 +116,7 @@ public static function table(Table $table): Table
 
                 Tables\Columns\TextColumn::make('max_values')
                     ->label(__('eclipse-catalogue::property.table.columns.max_values'))
-                    ->formatStateUsing(fn ($state) => $state === 1 ? __('eclipse-catalogue::property.format.max_values.single') : __('eclipse-catalogue::property.format.max_values.multiple')),
+                    ->numeric(),
 
                 Tables\Columns\IconColumn::make('enable_sorting')
                     ->label(__('eclipse-catalogue::property.table.columns.enable_sorting'))

src/Models/PropertyValue.php

@@ -59,6 +59,13 @@ protected static function newFactory(): PropertyValueFactory
         return PropertyValueFactory::new();
     }
 
+    protected static function booted(): void
+    {
+        static::addGlobalScope('orderBySort', function ($query) {
+            $query->orderBy('sort');
+        });
+    }
+
     /**
      * Ensure Filament receives scalar values for form hydration.
      *