fix: db structure fixes

Author: KilianTrunk

database/migrations/2025_08_19_172834_create_pim_property_value_table.php

@@ -13,13 +13,12 @@ public function up(): void
     {
         Schema::create('pim_property_value', function (Blueprint $table) {
             $table->id();
-            $table->foreignId('property_id')->constrained('pim_property')->onDelete('cascade');
+            $table->foreignId('property_id')->constrained('pim_property')->onDelete('cascade')->onUpdate('cascade');
             $table->string('value');
             $table->smallInteger('sort')->default(0);
             $table->string('info_url')->nullable();
             $table->string('image')->nullable();
             $table->timestamps();
-            $table->softDeletes();
         });
     }
 

database/migrations/2025_08_19_174519_create_pim_product_type_has_property_table.php

@@ -12,8 +12,8 @@
     public function up(): void
     {
         Schema::create('pim_product_type_has_property', function (Blueprint $table) {
-            $table->foreignId('product_type_id')->constrained('pim_product_types')->onDelete('cascade');
-            $table->foreignId('property_id')->constrained('pim_property')->onDelete('cascade');
+            $table->foreignId('product_type_id')->constrained('pim_product_types')->onDelete('cascade')->onUpdate('cascade');
+            $table->foreignId('property_id')->constrained('pim_property')->onDelete('cascade')->onUpdate('cascade');
             $table->smallInteger('sort')->nullable();
             $table->timestamps();
             $table->primary(['product_type_id', 'property_id']);

database/migrations/2025_08_19_175623_create_catalogue_product_has_property_value_table.php

@@ -12,8 +12,8 @@
     public function up(): void
     {
         Schema::create('catalogue_product_has_property_value', function (Blueprint $table) {
-            $table->foreignId('product_id')->constrained('catalogue_products')->onDelete('cascade');
-            $table->foreignId('property_value_id')->constrained('pim_property_value')->onDelete('cascade');
+            $table->foreignId('product_id')->constrained('catalogue_products')->onDelete('cascade')->onUpdate('cascade');
+            $table->foreignId('property_value_id')->constrained('pim_property_value')->onDelete('cascade')->onUpdate('cascade');
             $table->timestamps();
             $table->unique(['product_id', 'property_value_id'], 'product_property_value_unique');
         });

database/migrations/2025_08_19_175841_add_indexes_to_property_tables.php

@@ -7,14 +7,13 @@
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Database\Eloquent\Relations\BelongsTo;
 use Illuminate\Database\Eloquent\Relations\BelongsToMany;
-use Illuminate\Database\Eloquent\SoftDeletes;
 use Spatie\MediaLibrary\HasMedia;
 use Spatie\MediaLibrary\InteractsWithMedia;
 use Spatie\Translatable\HasTranslations;
 
 class PropertyValue extends Model implements HasMedia
 {
-    use HasFactory, HasTranslations, InteractsWithMedia, SoftDeletes;
+    use HasFactory, HasTranslations, InteractsWithMedia;
 
     protected $table = 'pim_property_value';
 
@@ -55,16 +54,6 @@ public function registerMediaCollections(): void
             ->useDisk('public');
     }
 
-    protected static function booted(): void
-    {
-        static::deleting(function (PropertyValue $value) {
-            if ($value->isForceDeleting()) {
-                // Delete product assignments
-                $value->products()->detach();
-            }
-        });
-    }
-
     protected static function newFactory(): PropertyValueFactory
     {
         return PropertyValueFactory::new();

src/Models/PropertyValue.php

@@ -152,22 +152,6 @@
     ]);
 });
 
-it('cascades delete to property values', function () {
-    $property = Property::factory()->create();
-    $value = PropertyValue::factory()->create(['property_id' => $property->id]);
-
-    // First soft delete, then force delete to test cascade
-    $property->delete();
-    $property->forceDelete();
-
-    $this->assertDatabaseMissing('pim_property', [
-        'id' => $property->id,
-    ]);
-
-    // Property value should also be force deleted due to cascade
-    expect(PropertyValue::withTrashed()->find($value->id))->toBeNull();
-});
-
 it('cascades delete to product type assignments', function () {
     $property = Property::factory()->create(['is_global' => false]);
     $productType = ProductType::factory()->create();

tests/Feature/PropertyCrudTest.php

@@ -213,27 +213,3 @@
         'property_id' => $property->id,
     ]);
 });
-
-it('deleting property value removes product assignments', function () {
-    $product = Product::factory()->create();
-    $property = Property::factory()->create();
-    $value = PropertyValue::factory()->create(['property_id' => $property->id]);
-
-    $product->propertyValues()->attach($value->id);
-
-    // Verify assignment exists
-    $this->assertDatabaseHas('catalogue_product_has_property_value', [
-        'product_id' => $product->id,
-        'property_value_id' => $value->id,
-    ]);
-
-    // First soft delete, then force delete to test cascade
-    $value->delete();
-    $value->forceDelete();
-
-    // Verify assignment is removed
-    $this->assertDatabaseMissing('catalogue_product_has_property_value', [
-        'product_id' => $product->id,
-        'property_value_id' => $value->id,
-    ]);
-});

tests/Feature/PropertyIntegrationTest.php

@@ -50,28 +50,6 @@
     ]);
 });
 
-it('can soft delete a property value', function () {
-    $value = PropertyValue::factory()->create();
-
-    $value->delete();
-
-    $this->assertSoftDeleted('pim_property_value', [
-        'id' => $value->id,
-    ]);
-});
-
-it('can restore a soft deleted property value', function () {
-    $value = PropertyValue::factory()->create();
-
-    $value->delete();
-    $value->restore();
-
-    $this->assertDatabaseHas('pim_property_value', [
-        'id' => $value->id,
-        'deleted_at' => null,
-    ]);
-});
-
 it('maintains sort order when creating multiple values', function () {
     $property = Property::factory()->create();
 

tests/Feature/PropertyValueCrudTest.php

@@ -84,27 +84,6 @@
     expect($sortedValues->last()->id)->toBe($value1->id);
 });
 
-it('can soft delete property value', function () {
-    $value = PropertyValue::factory()->create();
-    $id = $value->id;
-
-    $value->delete();
-
-    expect(PropertyValue::find($id))->toBeNull();
-    expect(PropertyValue::withTrashed()->find($id))->not->toBeNull();
-    expect(PropertyValue::withTrashed()->find($id)->trashed())->toBeTrue();
-});
-
-it('can restore soft deleted property value', function () {
-    $value = PropertyValue::factory()->create();
-    $value->delete();
-
-    $value->restore();
-
-    expect($value->trashed())->toBeFalse();
-    expect(PropertyValue::find($value->id))->not->toBeNull();
-});
-
 // Translation tests
 it('value attribute is translatable', function () {
     $value = PropertyValue::factory()->create([