Skip to content

chore(ci): revert change to use newest tag for CI images - #2223

Open
tobz wants to merge 1 commit into
mainfrom
tobz/fix-ci-image-latest-tag-stuff
Open

chore(ci): revert change to use newest tag for CI images#2223
tobz wants to merge 1 commit into
mainfrom
tobz/fix-ci-image-latest-tag-stuff

Conversation

@tobz

@tobz tobz commented Jul 28, 2026

Copy link
Copy Markdown
Member

Summary

As stated in the PR title.

Apparently most of our jobs were continuing to run due to a side effect of how Gitlab merges the CI configuration 1, but display-image-tags was broken and we only realized it after having a need to publish internal images for testing a PR.... doh! 😅

This PR simply reverts those changes, since the original circumstances for switching in the first place should no longer exist (even if they may return 🤷🏻) and this gets us to the desired state of supporting our rebuilt-weekly images and fixing the display-image-tags job.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

How did you test this PR?

  • Ran the internal image publish jobs on this PR and ensured that they ran as expected, including display-image-tags.

References

DADP-2

Footnotes

  1. It's not doing it weirdly, but based on how we specify images for jobs, we were overriding the portion of the default configuration that actually specified the pull policy... so basically all jobs other than display-image-tags had the overridden pull policy removed which is how they managed to run successfully.

@tobz
tobz requested a review from a team as a code owner July 28, 2026 19:00
@tobz tobz added the type/bug Bug fixes. label Jul 28, 2026
@dd-octo-sts dd-octo-sts Bot added the area/ci CI/CD, automated testing, etc. label Jul 28, 2026
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jul 28, 2026

Copy link
Copy Markdown

Pipelines

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 092058f | Docs | Datadog PR Page | Give us feedback!

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The helper-image references and promotion jobs are consistent after the revert: all four consumers resolve to :latest, the local CI YAML parses, and display-image-tags still emits both expected image tags without requiring a container image. No diff-induced behavioral regression was reproduced.

Was this helpful? React 👍 or 👎

📊 Validated against 5 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit 092058f · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@pr-commenter

pr-commenter Bot commented Jul 28, 2026

Copy link
Copy Markdown

Binary Size Analysis (Agent Data Plane)

Baseline: f90357b · Comparison: 092058f · diff
Analysis Configuration: stripped binaries · Pass/Fail Threshold: +5%
Sizes: 40.83 MiB (baseline) vs 40.83 MiB (comparison)
Size Change: -8 B (-0.00%)

✅ Binary size difference within threshold

Changes by Module
Module File Size Symbols
anon.44a0faa3240fa409baa379409d152aec.1.llvm.12655547928165574868 -130 B 1
anon.44a0faa3240fa409baa379409d152aec.1.llvm.3806687161993597852 +129 B 1
anon.44a0faa3240fa409baa379409d152aec.4.llvm.12655547928165574868 -114 B 1
anon.44a0faa3240fa409baa379409d152aec.4.llvm.3806687161993597852 +113 B 1
anon.44a0faa3240fa409baa379409d152aec.3.llvm.12655547928165574868 -109 B 1
anon.44a0faa3240fa409baa379409d152aec.3.llvm.3806687161993597852 +108 B 1
anon.44a0faa3240fa409baa379409d152aec.0.llvm.12655547928165574868 -97 B 1
anon.44a0faa3240fa409baa379409d152aec.0.llvm.3806687161993597852 +96 B 1
anon.44a0faa3240fa409baa379409d152aec.2.llvm.12655547928165574868 -95 B 1
anon.44a0faa3240fa409baa379409d152aec.2.llvm.3806687161993597852 +94 B 1
[Unmapped] -3 B 1
Detailed Symbol Changes
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW]    +129  [NEW]     +40    anon.44a0faa3240fa409baa379409d152aec.1.llvm.3806687161993597852
  [NEW]    +113  [NEW]     +24    anon.44a0faa3240fa409baa379409d152aec.4.llvm.3806687161993597852
  [NEW]    +108  [NEW]     +19    anon.44a0faa3240fa409baa379409d152aec.3.llvm.3806687161993597852
  [NEW]     +96  [NEW]      +7    anon.44a0faa3240fa409baa379409d152aec.0.llvm.3806687161993597852
  [NEW]     +94  [NEW]      +5    anon.44a0faa3240fa409baa379409d152aec.2.llvm.3806687161993597852
  -5.0%      -3  [ = ]       0    [Unmapped]
  [DEL]     -95  [DEL]      -5    anon.44a0faa3240fa409baa379409d152aec.2.llvm.12655547928165574868
  [DEL]     -97  [DEL]      -7    anon.44a0faa3240fa409baa379409d152aec.0.llvm.12655547928165574868
  [DEL]    -109  [DEL]     -19    anon.44a0faa3240fa409baa379409d152aec.3.llvm.12655547928165574868
  [DEL]    -114  [DEL]     -24    anon.44a0faa3240fa409baa379409d152aec.4.llvm.12655547928165574868
  [DEL]    -130  [DEL]     -40    anon.44a0faa3240fa409baa379409d152aec.1.llvm.12655547928165574868
  -0.0%      -8  [ = ]       0    TOTAL

@pr-commenter

pr-commenter Bot commented Jul 28, 2026

Copy link
Copy Markdown

Regression Detector (Agent Data Plane)

Run ID: 050b284d-6db5-437d-8c7d-9d881b2912c4
Baseline: f90357bd · Comparison: 092058f1 · diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment (3)

Experiments configured erratic: true are tagged (ignored) and skipped when determining which experiments regressed or improved. Experiments which are detected as erratic at runtime are tagged (erratic) to flag that the run's sample dispersion was high, but their regression / improvement signal still counts.

experiment goal Δ mean % links
quality_gates_rss_idle memory ⚪ +0.27 metrics profiles logs
quality_gates_rss_dsd_low memory ⚪ +0.14 metrics profiles logs
quality_gates_rss_dsd_medium memory ⚪ -0.33 metrics profiles logs
Bounds Checks: ✅ Passed (3)
experiment check replicates observed links
quality_gates_rss_dsd_low memory_usage 10/10 ✅ 45.5 MiB ≤ 50 MiB metrics profiles logs
quality_gates_rss_dsd_medium memory_usage 10/10 ✅ 67.9 MiB ≤ 75 MiB metrics profiles logs
quality_gates_rss_idle memory_usage 10/10 ✅ 31.4 MiB ≤ 40 MiB metrics profiles logs
Explanation

A change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression (is_regression: true). Improvements use the matching criteria for the improving direction. Experiments configured erratic: true (tagged (ignored)) are skipped outright; experiments detected as erratic at runtime (tagged (erratic)) still count, since that flag describes sample dispersion rather than directional certainty. The Δ mean % cell is colored accordingly: 🟢 = improvement, 🔴 = regression, ⚪ = neutral. Reduction in CPU or memory is an improvement; reduction in ingress throughput is a regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci CI/CD, automated testing, etc. type/bug Bug fixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants